Remove Browser#supportsPositionFixed and Skin#setupPositionFixedEmulation
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This is the outcome of T143334.

ac

Dead code is no longer in the repo
No dead tests or others

Details

	Subject	Repo	Branch	Lines +/-
	Remove Browser#supportsPositionFixed and Skin#setupPositionFixedEmulation	mediawiki/extensions/MobileFrontend	master	+0 -129

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Jhernandez	T143334 [SPIKE: 2hrs] Should we remove supportsPositionFixed and Skin#setupPositionFixedEmulation?
		Resolved		• jhobs	T144558 Remove Browser#supportsPositionFixed and Skin#setupPositionFixedEmulation

Event Timeline

• bmansurov created this task.Sep 1 2016, 10:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2016, 10:23 PM

• bmansurov mentioned this in T143334: [SPIKE: 2hrs] Should we remove supportsPositionFixed and Skin#setupPositionFixedEmulation?.Sep 1 2016, 10:24 PM

• Jhernandez added a parent task: T143334: [SPIKE: 2hrs] Should we remove supportsPositionFixed and Skin#setupPositionFixedEmulation?.Sep 6 2016, 3:34 PM

Dead code is a liability. My take on priority is High.

ovasileva added a project: Reading-Web-Sprint-81-We-suck-at-coming-up-with-sprint-names.Sep 7 2016, 3:19 PM

• Jhernandez updated the task description. (Show Details)Sep 7 2016, 3:20 PM

• Jhernandez triaged this task as High priority.Sep 7 2016, 3:34 PM

• Jhernandez moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.

• jhobs claimed this task.Sep 8 2016, 5:18 PM

• jhobs edited projects, added Reading-Web-Sprint-80-V-for-Vandalism, Unplanned-Sprint-Work; removed Reading-Web-Sprint-81-We-suck-at-coming-up-with-sprint-names.

• jhobs moved this task from 2016-17 Q2 to 2016-17 Q1 on the Web-Team-Backlog board.

• jhobs moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-80-V-for-Vandalism board.

@jhobs did you forget to move this to "Doing?"

No, I wasn't able to get to it by the end of the day, I was still catching
up from being out. Looks pretty simple though so I'll take care of it early
tomorrow so we can get a quick turnaround before the weekend.

• jhobs moved this task from To Do to Doing on the Reading-Web-Sprint-80-V-for-Vandalism board.Sep 9 2016, 2:31 PM

Change 309586 had a related patch set uploaded (by Jhobs):
Remove Browser#supportsPositionFixed and Skin#setupPositionFixedEmulation

https://gerrit.wikimedia.org/r/309586

gerritbot added a project: Patch-For-Review.Sep 9 2016, 3:08 PM

• jhobs moved this task from Doing to Code Review on the Reading-Web-Sprint-80-V-for-Vandalism board.Sep 9 2016, 3:08 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-80-V-for-Vandalism board.Sep 9 2016, 6:33 PM

• jhobs moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-80-V-for-Vandalism board.Sep 9 2016, 6:53 PM