Page MenuHomePhabricator

Fix Browser#supportsPositionFixed
Closed, DeclinedPublic3 Estimated Story Points

Description

Depends on the results of T143334 (if we have to remove the code then this task is invalid).


@Jhernandez via email:

supportsPositionFixed (browser.js) is doing a positive check on UAs, only reporting true for known UAs.

That may mean that future modern browsers could report false if the UA changes, so the method is extremely brittle.

We should change it to reject known problematic UAs instead of approving a few ones for future proofness.

Event Timeline

jhobs triaged this task as Medium priority.Aug 18 2016, 5:14 PM
jhobs moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.

I'm not sure, if we have a list of the known problematic browsers, then a 2 sounds good. If not, then a 5 for finding those browsers and testing this feature against those browsers (qUnit tests).

MBinder_WMF set the point value for this task to 3.Aug 24 2016, 4:23 PM

This is fixing supportsPositionFixed to work on the codebase, but in any case this.on('scroll' in the skin would still not trigger, so additional tasks will be needed to fix the emulation and test it in old devices if necessary.

In favor of T144558, given the results of T143334