Page MenuHomePhabricator
Create Task
Maniphest T145834

SearchFragment should be hosted in its own Activity
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

SearchFragment should be hosted in its own Activity, SearchActivity. This will keep separation of concerns, make dependencies explicit, and may eliminate some of the Fragment backstack logic.

Details

SubjectRepoBranchLines +/-
Split off SearchFragment into its own Activityapps/android/wikipediamaster+94 -306
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niedzielski created this task.Sep 16 2016, 2:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2016, 2:12 AM
• Niedzielski added a project: Mobile-App-Android-Sprint-92-Uranium.Sep 16 2016, 6:29 PM
MBinder_WMF set the point value for this task to 3.Sep 16 2016, 6:46 PM
Dbrant moved this task from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.Sep 21 2016, 4:19 PM
MBinder_WMF removed a project: Mobile-App-Android-Sprint-92-Uranium.Sep 23 2016, 6:28 PM
• Mholloway triaged this task as Medium priority.Sep 30 2016, 8:38 PM
• Niedzielski added a parent task: T150662: Soft keyboard should resize Search Activity.Nov 14 2016, 4:25 PM
• Niedzielski added a parent task: T150997: Opening search should hide nav toolbar.Nov 17 2016, 10:25 PM
• Niedzielski mentioned this in T150997: Opening search should hide nav toolbar.
gerritbot subscribed.Oct 30 2018, 12:00 AM

Change 469811 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Split off SearchFragment into its own Activity

https://gerrit.wikimedia.org/r/469811

gerritbot added a project: Patch-For-Review.Oct 30 2018, 12:00 AM
gerritbot added a comment.Nov 29 2018, 7:27 PM

Change 469811 merged by jenkins-bot:
[apps/android/wikipedia@master] Split off SearchFragment into its own Activity

https://gerrit.wikimedia.org/r/469811

Dbrant closed this task as Resolved.Jan 3 2019, 6:15 PM
Dbrant claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL