Page MenuHomePhabricator

Unable to view notifications in Echo
Closed, ResolvedPublic

Description

Caught by browser test and now blocking all MobileFrontend merges:
https://integration.wikimedia.org/ci/job/mwext-mw-selenium/10247/console

Notifications overlay is broken on mobile site.
The error reported in the JS console is:
TypeError: Cannot read property 'bind' of undefined
and it seems to have been introduced by 1575e2bb7a2f686ba4fba71c19bfd70b4c18abc7

Side note: Should MobileFrontend run our browser test suite - this has happened a few times now.

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 21 2016, 8:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 312105 had a related patch set uploaded (by Jdlrobson):
Revert "Convert 'seenTime' to a global property"

https://gerrit.wikimedia.org/r/312105

Jdlrobson triaged this task as Unbreak Now! priority.Sep 21 2016, 8:37 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptSep 21 2016, 8:37 PM

@Jdlrobson Should this be in the sprint? MobileFrontend + Patch-For-Review + your patch :)

Dealing with this right now. There's a small change we forgot to make when fixing global seen time - I'm submitting now. There's no need to revert the whole seenTime change.

Change 312112 had a related patch set uploaded (by Mooeypoo):
Followup I67bcc4b34: Update call to global seenTime

https://gerrit.wikimedia.org/r/312112

Change 312112 merged by jenkins-bot:
Followup I67bcc4b34: Update call to global seenTime

https://gerrit.wikimedia.org/r/312112

Fixed for me locally and seems to be passing tests. Can you confirm this is fixed, @Jdlrobson ? Can we abandon the revert patch?

Checked in betalabs mobile

Change 312105 abandoned by Jdlrobson:
Revert "Convert 'seenTime' to a global property"

Reason:
Feel free to abandon these in future. I never get offended by abandons and sometimes forget. :) thanks again for fixing so quickly!

https://gerrit.wikimedia.org/r/312105

Jdlrobson closed this task as Resolved.Sep 22 2016, 8:43 PM

Last build passed: https://integration.wikimedia.org/ci/view/Selenium/job/selenium-MobileFrontend/167/ (we've been having some turbulence) but this looks fixed to me.