Page MenuHomePhabricator
Create Task
Maniphest T147536

Disable magic link functionality by default in MediaWiki
Closed, ResolvedPublic
Actions

Description

  • Set default in Wikimedia config to be true
  • Ensure RFC and PMID are in the interwiki map
  • Set default in MediaWiki core to be false

Details

SubjectRepoBranchLines +/-
Disable magic links by defaultmediawiki/coreREL1_28+9 -3
Disable magic links by defaultmediawiki/coremaster+9 -3
addRFCandPMIDInterwiki: Fix strict mode errorsmediawiki/coremaster+10 -1
Enable magic links regardless of MediaWiki core defaultoperations/mediawiki-configmaster+9 -0
Add 'pmid' to the default interwiki list, and update 'rfc'mediawiki/coremaster+92 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Oct 6 2016, 1:04 AM
Restricted Application added subscribers: JEumerus, Matanya, Aklapper. · View Herald TranscriptOct 6 2016, 1:04 AM
JJMC89 subscribed.Oct 6 2016, 1:07 AM
gerritbot subscribed.Oct 6 2016, 1:07 AM

Change 314463 had a related patch set uploaded (by Legoktm):
Enable magic links regardless of MediaWiki core default

https://gerrit.wikimedia.org/r/314463

gerritbot added a project: Patch-For-Review.Oct 6 2016, 1:07 AM
gerritbot added a comment.Oct 6 2016, 2:58 AM

Change 314474 had a related patch set uploaded (by Legoktm):
Add 'pmid' to the default interwiki list, and update 'rfc'

https://gerrit.wikimedia.org/r/314474

Legoktm added a comment.Oct 6 2016, 3:17 AM

PMID has been proposed for addition to the Wikimedia interwiki map https://meta.wikimedia.org/wiki/Talk:Interwiki_map#PMID

Dereckson moved this task from Backlog to To deploy on the Wikimedia-Site-requests board.Oct 6 2016, 10:33 AM
Dereckson subscribed.

The English Wikipedia seems to use PMID magic links currently.

https://en.wikipedia.org/wiki/Wikipedia:PMID

gerritbot added a comment.Oct 6 2016, 10:40 PM

Change 314474 merged by jenkins-bot:
Add 'pmid' to the default interwiki list, and update 'rfc'

https://gerrit.wikimedia.org/r/314474

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 6 2016, 11:00 PM
• MZMcBride subscribed.Oct 9 2016, 1:03 AM
Huji subscribed.EditedOct 11 2016, 1:23 PM

@Legoktm ever since 314474 has been merged, I get error messages when running the update script stating that the iw_api value does not have a default. I fixed it by temporarily passing a default value, and I see from DB schema that it does have a default of NULL. Thought I should report it anyway.

gerritbot added a comment.Oct 15 2016, 6:23 AM

Change 314463 merged by jenkins-bot:
Enable magic links regardless of MediaWiki core default

https://gerrit.wikimedia.org/r/314463

Legoktm updated the task description. (Show Details)Oct 15 2016, 6:35 AM
Legoktm created subtask T148274: Implement a convenient way to link to ISBNs without magic links.Oct 15 2016, 7:40 AM
gerritbot added a comment.Oct 15 2016, 7:28 PM

Change 316080 had a related patch set uploaded (by Legoktm):
addRFCandPMIDInterwiki: Fix strict mode errors

https://gerrit.wikimedia.org/r/316080

Legoktm added a comment.Oct 15 2016, 7:28 PM
In T147536#2705540, @Huji wrote:

@Legoktm ever since 314474 has been merged, I get error messages when running the update script stating that the iw_api value does not have a default. I fixed it by temporarily passing a default value, and I see from DB schema that it does have a default of NULL. Thought I should report it anyway.

Thanks, after enabling MySQL strict mode I can reproduce. I submitted a patch for it.

gerritbot added a comment.Oct 16 2016, 1:42 AM

Change 316080 merged by jenkins-bot:
addRFCandPMIDInterwiki: Fix strict mode errors

https://gerrit.wikimedia.org/r/316080

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 16 2016, 2:00 AM
JJMC89 added a subtask: T149310: The ISBN magic word puts Commons pages containing it into a non-existent category..Oct 27 2016, 3:14 PM
Legoktm closed subtask T149310: The ISBN magic word puts Commons pages containing it into a non-existent category. as Resolved.Oct 27 2016, 6:37 PM
Liuxinyu970226 subscribed.Oct 29 2016, 12:24 AM
Dereckson moved this task from To deploy to Done on the Wikimedia-Site-requests board.Nov 3 2016, 11:59 AM
gerritbot added a comment.Nov 3 2016, 6:17 PM

Change 319633 had a related patch set uploaded (by Legoktm):
Disable magic links by default

https://gerrit.wikimedia.org/r/319633

gerritbot added a comment.Nov 4 2016, 2:38 AM

Change 319633 merged by jenkins-bot:
Disable magic links by default

https://gerrit.wikimedia.org/r/319633

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 4 2016, 3:00 AM
gerritbot added a comment.Nov 4 2016, 3:44 AM

Change 319784 had a related patch set uploaded (by Legoktm):
Disable magic links by default

https://gerrit.wikimedia.org/r/319784

Legoktm closed this task as Resolved.Nov 4 2016, 3:46 AM
gerritbot added a comment.Nov 4 2016, 3:56 AM

Change 319784 merged by jenkins-bot:
Disable magic links by default

https://gerrit.wikimedia.org/r/319784

Liuxinyu970226 unsubscribed.Nov 4 2016, 9:19 AM
JJMC89 added a subtask: T150489: Some strange category on uk.wikipedia.org.Nov 10 2016, 11:32 PM
Legoktm removed a subtask: T150489: Some strange category on uk.wikipedia.org.Nov 10 2016, 11:38 PM
IKhitron subscribed.Nov 12 2016, 2:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits