EditFilterMerged hook usage needs replacing!
Use EditFilterMergedContent instead.
EditFilterMerged hook usage needs replacing!
Use EditFilterMergedContent instead.
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Replace EditFilterMerged hook usage | mediawiki/extensions/UploadWizard | master | +15 -11 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Filip | T145728 Clean up ContentHandler deprecated functions and hooks | |||
Resolved | Reedy | T147391 Hook EditFilterMerged is deprecated | |||
Resolved | Reedy | T147566 UploadWizard uses deprecated EditFilterMerged hook |
Why do we even need this… we apparently do some namespace-specific validation in it. Isn't ContentHandler supposed to call the validation functions automatically?
It would indeed be nice if ContentHandler had a validate() methods that returns a Status object (or would return a meaningful message in some other way). But this is not the case, all we have right now is Content::isValue() which only returns a boolean. So using EditFilterMergedContent to do pre-save validation is probably the best option for now.
Change 314625 had a related patch set uploaded (by Reedy):
Replace EditFilterMerged hook usage