Page MenuHomePhabricator
Create Task
Maniphest T148195

Feature flag categories feature
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Nicholas.tsg
Authored By
• bmansurov
Oct 14 2016, 4:16 PM
Tags
Referenced Files
F4869070: T148195 iPad Air 2 iOS 10.2 (Safari).PNG
Nov 27 2016, 7:47 PM
F4869043: T148195 Samsung Galaxy Tab 4 (Browser, in Beta Mode).png
Nov 27 2016, 7:47 PM
F4869068: T148195 iPad Air 2 iOS 10.2 (Firefox, in Beta Mode).PNG
Nov 27 2016, 7:47 PM
F4869072: T148195 iPad Air 2 iOS 10.2 (Safari, in Beta Mode).PNG
Nov 27 2016, 7:47 PM
F4869047: T148195 Samsung Galaxy Tab 4 (Chrome, in Beta Mode).png
Nov 27 2016, 7:47 PM
F4869053: T148195 iPad Air 2 iOS 10.2 (Chrome).PNG
Nov 27 2016, 7:47 PM
F4869060: T148195 iPad Air 2 iOS 10.2 (Chrome, in Beta Mode).PNG
Nov 27 2016, 7:47 PM
F4869045: T148195 Samsung Galaxy Tab 4 (Chrome).png
Nov 27 2016, 7:47 PM
View All 10 Files
Subscribers
Aklapper
• bmansurov
gerritbot
Jdlrobson
• jhobs
Nemo_bis
phuedx

Description

In order to remove SkinMinervaBeta, feature flag the categories feature and move the code into MinervaTemplate.php/SkinMinerva.php

Test Plan

Details

SubjectRepoBranchLines +/-
Feature flag categoriesmediawiki/extensions/MobileFrontendmaster+102 -51
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bmansurov created this task.Oct 14 2016, 4:16 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 14 2016, 4:16 PM
• bmansurov removed a project: Epic.Oct 14 2016, 4:24 PM
• bmansurov moved this task from Uncategorized to Clean-Up on the Technical-Debt (RW-Tech-Debt) board.Oct 14 2016, 4:26 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Oct 20 2016, 7:49 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Oct 26 2016, 5:54 PM
ovasileva added a project: Reading-Web-Sprint-86-🔪🦃.Nov 11 2016, 4:33 PM
MBinder_WMF set the point value for this task to 2.Nov 15 2016, 5:41 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-86-🔪🦃 board.Nov 21 2016, 5:55 PM
ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Nov 21 2016, 7:47 PM
• bmansurov claimed this task.Nov 22 2016, 3:04 PM
• bmansurov moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-86-🔪🦃 board.
• bmansurov moved this task from Blocked Externally to Doing on the Reading-Web-Sprint-86-🔪🦃 board.
gerritbot added a comment.Nov 22 2016, 9:03 PM

Change 322967 had a related patch set uploaded (by Bmansurov):
Feature flag categories

https://gerrit.wikimedia.org/r/322967

gerritbot added a project: Patch-For-Review.Nov 22 2016, 9:03 PM
• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-86-🔪🦃 board.Nov 22 2016, 9:04 PM
Nemo_bis subscribed.Nov 23 2016, 6:54 AM

There is no need of a configuration for this, categories should be shown unconditionally.

Jdlrobson moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-86-🔪🦃 board.Nov 23 2016, 6:18 PM

There are some really minor comments on the patch. Once those are addressed ping me to merge.

• bmansurov moved this task from Needs More Work to Doing on the Reading-Web-Sprint-86-🔪🦃 board.Nov 23 2016, 6:34 PM
• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-86-🔪🦃 board.Nov 23 2016, 11:22 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-86-🔪🦃 board.Nov 24 2016, 12:00 AM
gerritbot added a comment.Nov 24 2016, 12:10 AM

Change 322967 merged by jenkins-bot:
Feature flag categories

https://gerrit.wikimedia.org/r/322967

• bmansurov reassigned this task from • bmansurov to Nicholas.tsg.Nov 24 2016, 12:16 AM
• bmansurov updated the task description. (Show Details)
• bmansurov moved this task from Ready for Signoff to Needs QA on the Reading-Web-Sprint-86-🔪🦃 board.
Nicholas.tsg added a comment.Nov 27 2016, 7:47 PM

This appears to be fixed, with the Categories button being visible/not as expected, according to screencap results for testing on different devices/browsers:

Samsung Galaxy Tab 4 (Browser)

T148195 Samsung Galaxy Tab 4 (Browser).png (1×800 px, 66 KB)

Samsung Galaxy Tab 4 (Browser, in Beta Mode)
T148195 Samsung Galaxy Tab 4 (Browser, in Beta Mode).png (1×800 px, 67 KB)

Samsung Galaxy Tab 4 (Chrome)
T148195 Samsung Galaxy Tab 4 (Chrome).png (1×800 px, 74 KB)

Samsung Galaxy Tab 4 (Chrome, in Beta Mode)
T148195 Samsung Galaxy Tab 4 (Chrome, in Beta Mode).png (1×800 px, 81 KB)

iPad Air 2 iOS 10.2 (Chrome)
T148195 iPad Air 2 iOS 10.2 (Chrome).PNG (2×1 px, 135 KB)

iPad Air 2 iOS 10.2 (Chrome, in Beta Mode)
T148195 iPad Air 2 iOS 10.2 (Chrome, in Beta Mode).PNG (2×1 px, 143 KB)

iPad Air 2 iOS 10.2 (Firefox)
T148195 iPad Air 2 iOS 10.2 (Firefox).PNG (2×1 px, 124 KB)

iPad Air 2 iOS 10.2 (Firefox, in Beta Mode)
T148195 iPad Air 2 iOS 10.2 (Firefox, in Beta Mode).PNG (2×1 px, 133 KB)

iPad Air 2 iOS 10.2 (Safari)
T148195 iPad Air 2 iOS 10.2 (Safari).PNG (2×1 px, 121 KB)

iPad Air 2 iOS 10.2 (Safari, in Beta Mode)
T148195 iPad Air 2 iOS 10.2 (Safari, in Beta Mode).PNG (2×1 px, 129 KB)

Nicholas.tsg moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-86-🔪🦃 board.Nov 27 2016, 7:48 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 28 2016, 1:00 AM
ovasileva closed this task as Resolved.Nov 28 2016, 11:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits