Worked on in Wikispeech (Sprint 2016-11-30):

• Tentative code from T133680 migrated to this branch

To do in Wikispeech (Sprint 2016-12-14):

• Design and implementation

Adding <span> is tricky when they span multiple nodes. E.g. adding a <span> over "monkey penguin" in:

monkey
<b>
  penguin giraffe
</b>

doesn't work, since it would be broken HTML:

<span>
  monkey
  <b>
    penguin</span> giraffe
  </b>

While there are some methods for [[https://developer.mozilla.org/en-US/docs/Web/API/Range | Range]] that looked promising (like surroundContents() and insertNode()) experimenting with them has shown that they add/split elements, making it hard to remove the <span>.

I'm currently working on a solution that will instead find all the text nodes that should get highlighted and adding a <span> for each of them. Removing these later shouldn't be too hard and should leave the HTML intact. A (at the time of writing ugly) draft for getting all text nodes between to nodes can be seen here.

I have a reasonably working version of this locally. It still needs a bit more testing and, cleaning and merging.

Worked on in Wikispeech (Sprint 2016-12-14):

• Working prototype done

To do in Wikispeech (Sprint 2017-01-25):

• Clean up code
• Commit and review

The current under development solution uses index paths ([1, 0 ,4]) to find the correct nodes. Could Xpath be used instead? See https://developer.mozilla.org/en-US/docs/Introduction_to_using_XPath_in_JavaScript.

According to old system, will be updated to 1 Story Point = 1 hour tomorrow

Worked on in Wikispeech (Sprint 2017-01-25):

• Solution using DOM-based paths to find the correct text nodes from utterances
• Removed position of token+utterance which has proved to no longer be needed

To do in Wikispeech (Sprint 2017-02-08):

• Documentation for new functions, de-linting, rebase
• Commit
• Review-cycle [André]
• Create follow-up tasks for investigating use of XPath

Changed story points to new system

Change 336816 had a related patch set uploaded (by Sebastian Berlin (WMSE)):
Highlight recited sentence

https://gerrit.wikimedia.org/r/336816

Worked on in Wikispeech (Sprint 2017-02-08):

• Committed and ready for review

To do in Wikispeech (Sprint 2017-02-22):

• Review-cycle [André]
• Create follow-up tasks for investigating use of XPath

Change 336816 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech] Highlight recited sentence

https://gerrit.wikimedia.org/r/336816

Mentioned in SAL (#wikimedia-labs) [2017-03-03T15:06:10Z] <Sebastian_> Deploy latest from Git master: e2fbe6a (T148622)