The current method of getting the text nodes related to an utterance uses a path made up of indices, e.g. [1, 0, 3]. it looks like i should be possible to replaced this by XPath-expressions, with all the benefits of using a standard implementation.
So lets do that.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use XPath to get text nodes for utterances. | mediawiki/extensions/Wikispeech | master | +223 -731 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Sebastian_Berlin-WMSE | T158954 Use XPath to get text nodes related to utterances | |||
| Resolved | Sebastian_Berlin-WMSE | T148622 Highlight recited sentence |
While not necessary for T148623: Highlight recited word, I think it's better to take a look at this first.
I have an implementation of this that works, but still needs a bit of clean up and updating of tests. This will wait until T148622: Highlight recited sentence is done, to minimize extra work with merging.
A highlight of using XPath is that all the code in Cleaner that deals with extracting tags from the HTML is no longer needed.
Note the change of scope for the task.
Worked on in Wikispeech (Sprint 2017-02-22):
To do in Wikispeech (Sprint 2017-03-08):
While not directly related to this task, I discovered that CleanedTags are not needed currently. They were required for calculating character positions in the original HTML. Some representation of tags is likely needed for T133689: Recognise certain tags, notify user and allow interaction (was: Pling on navigation), but only for the elements that should give some kind of feedback.
Change 342024 had a related patch set uploaded (by Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech] Use XPath to get text nodes for utterances.
Worked on in Wikispeech (Sprint 2017-03-08):
To do in Wikispeech (Sprint 2017-03-22):
Change 342024 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Use XPath to get text nodes for utterances.
Mentioned in SAL (#wikimedia-labs) [2017-03-23T12:33:40Z] <Sebastian-WMSE> Deploy latest from Git master: e41c0c2 (T146459, T158954)