Page MenuHomePhabricator
Create Task
Maniphest T149194

Owner-only consumer fails when Identifying over OAuth
Closed, ResolvedPublic
Actions

Description

Anomie has more details on what's causing it, but when trying to run identify on OAuth it returns a mwoauth-invalid-authorization-not-approved error. This error says the current user can't use this consumer. That would make sense for unapproved consumers, but not for owner-only.

Details

SubjectRepoBranchLines +/-
Use correct user for isUsableBy check in Special:OAuth/identifymediawiki/extensions/OAuthREL1_26+7 -7
Use correct user for isUsableBy check in Special:OAuth/identifymediawiki/extensions/OAuthREL1_23+7 -7
Use correct user for isUsableBy check in Special:OAuth/identifymediawiki/extensions/OAuthREL1_27+7 -7
Use correct user for isUsableBy check in Special:OAuth/identifymediawiki/extensions/OAuthwmf/1.28.0-wmf.23+7 -7
Use correct user for isUsableBy check in Special:OAuth/identifymediawiki/extensions/OAuthwmf/1.28.0-wmf.22+7 -7
Use correct user for isUsableBy check in Special:OAuth/identifymediawiki/extensions/OAuthmaster+7 -7
Customize query in gerrit

Related Objects

Event Timeline

Cyberpower678 created this task.Oct 26 2016, 2:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2016, 2:23 PM
Cyberpower678 triaged this task as High priority.Oct 26 2016, 2:24 PM
gerritbot subscribed.Oct 26 2016, 2:26 PM

Change 318098 had a related patch set uploaded (by Anomie):
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318098

gerritbot added a project: Patch-For-Review.Oct 26 2016, 2:26 PM
Matthewrbowker subscribed.Oct 26 2016, 4:35 PM
gerritbot added a comment.Oct 26 2016, 10:47 PM

Change 318098 merged by jenkins-bot:
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318098

gerritbot added a comment.Oct 26 2016, 10:48 PM

Change 318219 had a related patch set uploaded (by Gergő Tisza):
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318219

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Oct 26 2016, 11:00 PM
gerritbot added a comment.Oct 27 2016, 12:29 AM

Change 318236 had a related patch set uploaded (by Gergő Tisza):
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318236

gerritbot added a comment.Oct 27 2016, 12:32 AM

Change 318236 merged by jenkins-bot:
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318236

gerritbot added a comment.Oct 27 2016, 12:32 AM

Change 318219 merged by jenkins-bot:
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318219

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 27 2016, 1:00 AM
Stashbot subscribed.Oct 27 2016, 2:31 AM

Mentioned in SAL (#wikimedia-operations) [2016-10-27T02:31:17Z] <tgr@tin> Synchronized php-1.28.0-wmf.22/extensions/OAuth/: deploy fix for T149194 (duration: 00m 51s)

Stashbot added a comment.Oct 27 2016, 2:32 AM

Mentioned in SAL (#wikimedia-operations) [2016-10-27T02:32:32Z] <tgr@tin> Synchronized php-1.28.0-wmf.23/extensions/OAuth/: deploy fix for T149194 (duration: 00m 47s)

Tgr closed this task as Resolved.Oct 27 2016, 3:03 AM
Tgr mentioned this in T148600: OAuth /identify endpoint does not check whether consumer is approved.Oct 27 2016, 11:13 PM
gerritbot added a comment.Oct 27 2016, 11:13 PM

Change 318458 had a related patch set uploaded (by Gergő Tisza):
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318458

gerritbot added a comment.Oct 27 2016, 11:14 PM

Change 318459 had a related patch set uploaded (by Gergő Tisza):
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318459

gerritbot added a comment.Oct 27 2016, 11:15 PM

Change 318460 had a related patch set uploaded (by Gergő Tisza):
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318460

gerritbot added a comment.Oct 27 2016, 11:21 PM

Change 318458 merged by jenkins-bot:
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318458

gerritbot added a comment.Oct 27 2016, 11:41 PM

Change 318460 merged by Gergő Tisza:
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318460

gerritbot added a comment.Oct 27 2016, 11:42 PM

Change 318459 merged by Gergő Tisza:
Use correct user for isUsableBy check in Special:OAuth/identify

https://gerrit.wikimedia.org/r/318459

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 4:01 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits