Steps to reproduce:
- Try to add/edit a comment
- Click on "Get Diff"
It does not show any changes related with "Comment" node
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T143341 When re-starting a local draft, show the user a diff so they know what they're getting into | |||
| Open | None | T105173 HTML diffs of edits for everything | |||
| Resolved | Tchanders | T143350 Let users choose a visual or wikitext diff in the review-your-changes tab | |||
| Resolved | Tchanders | T149821 Visual Diff does not show changes related with "Comment" |
Event Timeline
Comment Actions
Change 339022 had a related patch set uploaded (by Tchanders):
WIP Show comments in visual diff
Comment Actions
Some thoughts:
- The diff view is meant to represent the document as it would appear to a reader, not an editor, so we shouldn't suddenly display comments if they are unchanged
- However, the differ is a tool for editors to see what they have changed, so we should draw attention to inserted/removed/changed comments somehow
- Perhaps a happy compromise would be to treat comment diffs like attribute diffs (e.g. bolding a word), so highlight the place where the comment is/was to show that something has changed there, but show the details of the change elsewhere (the same place where we display details of attribute changes)
Comment Actions
Change 339022 merged by jenkins-bot:
Highlight comment changes in visual diff and fix whitespace
Comment Actions
Change 340446 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/VisualEditor] Update VE core submodule to master (15f36bc75)
Comment Actions
Change 361516 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] Include message for comment diff
Comment Actions
Change 361516 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Include message for comment diff