Special:Notifications doesn't use actual headers for headers in its list
Closed, ResolvedPublic
Actions

Description

The page features visual headers, per date, but these headers are not semantic headers. These elements should use a semantic element.

<div class="mw-echo-ui-subGroupListWidget-header">
  <div class="mw-echo-ui-subGroupListWidget-header-row">
    <span class="mw-echo-ui-subGroupListWidget-header-row-title oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement-label oo-ui-labelWidget oo-ui-labelElement" aria-disabled="false">
      <span class="mw-echo-ui-datedSubGroupListWidget-title">
        <span class="mw-echo-ui-datedSubGroupListWidget-title-primary">27 October 2016</span>
        <span class="mw-echo-ui-datedSubGroupListWidget-title-secondary"></span>
      </span>
    </span>
    <div class="mw-echo-ui-subGroupListWidget-header-row-markAllReadButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-framed oo-ui-iconElement oo-ui-labelElement oo-ui-buttonWidget oo-ui-element-hidden" aria-disabled="false">
      <a class="oo-ui-buttonElement-button" role="button" tabindex="0" aria-disabled="false" rel="nofollow">
        <span class="oo-ui-iconElement-icon oo-ui-icon-doubleCheck"></span>
        <span class="oo-ui-labelElement-label">Mark group as read</span>
        <span class="oo-ui-indicatorElement-indicator"></span>
      </a>
    </div>
  </div>
</div>

Details

	Subject	Repo	Branch	Lines +/-
	Make date headings a proper semantic <h2> heading	mediawiki/extensions/Echo	master	+10 -3

Customize query in gerrit

Event Timeline

TheDJ created this task.Nov 3 2016, 9:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2016, 9:29 PM

Aklapper added a project: Collab-Notifications-Page.Nov 4 2016, 10:41 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 4 2016, 10:41 AM

TheDJ added a project: Accessibility.Nov 4 2016, 12:13 PM

TheDJ updated the task description. (Show Details)Nov 7 2016, 8:45 AM

• jmatazzoni moved this task from Untriaged to Hot on the Collaboration-Team-Triage board.Nov 18 2016, 12:30 AM

Ricordisamoa renamed this task from Special:Notifications doesn't use actual headers for headers in it's list to Special:Notifications doesn't use actual headers for headers in its list.Mar 6 2017, 1:10 AM

Change 348015 had a related patch set uploaded (by Mooeypoo):
[mediawiki/extensions/Echo@master] Make date headings a proper semantic <h2> heading

https://gerrit.wikimedia.org/r/348015

gerritbot added a project: Patch-For-Review.Apr 12 2017, 11:52 PM

Mooeypoo claimed this task.Apr 12 2017, 11:52 PM

Mooeypoo edited projects, added Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed Collaboration-Team-Triage.

Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.

Change 348015 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Make date headings a proper semantic <h2> heading

https://gerrit.wikimedia.org/r/348015

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 13 2017, 11:00 PM

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 17 2017, 6:56 PM

Checked in betalabs - <h2 class="mw-echo-ui-datedSubGroupListWidget-title"> is in place:

<div class="mw-echo-ui-subGroupListWidget-header">
   <div class="mw-echo-ui-subGroupListWidget-header-row">
     <label class="mw-echo-ui-subGroupListWidget-header-row-title oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement-label oo-ui-labelWidget oo-ui-labelElement" aria-disabled="false">
     <h2 class="mw-echo-ui-datedSubGroupListWidget-title">
       <span class="mw-echo-ui-datedSubGroupListWidget-title-primary">Today</span>
       <span class="mw-echo-ui-datedSubGroupListWidget-title-secondary">19 April 2017</span>
     </h2>
     </label>
    <span class="mw-echo-ui-subGroupListWidget-header-row-markAllReadButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-framed oo-ui-iconElement oo-ui-labelElement oo-ui-buttonWidget" aria-disabled="false">
           <a class="oo-ui-buttonElement-button" role="button" tabindex="0" aria-disabled="false" rel="nofollow">
               <span class="oo-ui-iconElement-icon oo-ui-icon-doubleCheck"></span>
               <span class="oo-ui-labelElement-label">Mark group as read</span>
               <span class="oo-ui-indicatorElement-indicator"></span>
           </a>
    </span>
   </div>
</div>

Etonkovidova moved this task from QA Review to Done on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 20 2017, 12:45 AM

SamanthaNguyen moved this task from Unsorted to Semantic HTML on the Accessibility board.Apr 20 2017, 12:47 AM

Catrope closed this task as Resolved.May 4 2017, 12:11 AM

Special:Notifications doesn't use actual headers for headers in its listClosed, ResolvedPublicActions

Description

Details

Event Timeline

Special:Notifications doesn't use actual headers for headers in its list
Closed, ResolvedPublic
Actions