Page MenuHomePhabricator

CentralNotice banner(s) uses deprecated hideBanner
Open, LowestPublic

Description

The last banner I closed on enwiki used the deprecated method hideBanner. I remember reporting something similar a few months ago, and it was fixed back then, so maybe someone copied an outdated version as a template for the current one?

Event Timeline

He7d3r created this task.Nov 23 2016, 8:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2016, 8:11 PM
Jseddon claimed this task.Nov 24 2016, 8:40 AM
Jseddon triaged this task as Lowest priority.
Jseddon added a subscriber: Jseddon.

https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/WAM_2016 it's using a few deprecated bits of code. I'll clear it up later :)

TheDJ added a subscriber: TheDJ.Nov 25 2016, 9:38 AM

At the same time, please fix the included images to have width and height attributes... Without them, they sometimes resize across my entire viewport.

This is also happening for the banner about meta:The Wikipedia Library/1Lib1Ref

He7d3r updated the task description. (Show Details)Feb 4 2017, 8:51 PM
Elitre added a subscriber: Elitre.Feb 9 2017, 4:06 PM
Aklapper removed Jseddon as the assignee of this task.Jun 19 2020, 4:31 PM

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)