Page MenuHomePhabricator

Thank you letter from civi mangles non-$ currencies
Closed, ResolvedPublic2 Estimated Story Points

Description

The letter that goes out when re-sending from CiviCRM mangles non $ curencies at the html level - follow on from Bug T137496 which listed it's limitations as

  • The template is cut down from our standard thank you in the following ways *
  • 1) I pretty much by-passed translation - I’m thinking this is mostly for a small number of English language receipts
  • to be manually generated. I’d need to do something more complex to get it translating well
  • 2) I ditched the RecurringRestarted & UnrecordedCharge logic. I figured you would be sending these on request.
  • 3)I have assumed we have a first name & not done the fall-back to donor (on assumption manual sends know the name).
  • 4) I did not include "{% if recurring %}<p> This donation is part of a recurring subscription. Monthly payments will be debited by the Wikimedia Foundation until you notify us to stop. If you’d like to cancel the payments please see our <a href="https://wikimediafoundation.org/wiki/Special:LandingCheck?landing_page=Cancel_or_change_recurring_payment..
  • In other words this is a pretty-simple English language solution.

Event Timeline

Hi @Eileenmcnaughton. Please associate at least one project with this task to allow others to find this task when searching in the corresponding project(s). Thanks!

Hi @Eileenmcnaughton I have 2 questions related to this workflow:

  1. Does the TY email work for check donations?
  2. If so would we expect the View Contact - Contributions list to reflect the TY sent date? Or would this only appear once you view the details for the specific donation? We tested this for cid=19900401 and here's what we see. Did the TY email get sent?

cid19900401.jpg (918×2 px, 317 KB)

Worth noting that you can actually see currencies mis-displayed in the UI too sometimes on contact contribution tabs

Change 353387 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/crm@master] Smarty modifier converts all currencies available to civi T151957

https://gerrit.wikimedia.org/r/353387

I went down the wrong rabbit hole as it turns out, but @Eileenmcnaughton your tip about the form got me back on track! I think this is related to this issue: https://forum.civicrm.org/index.php?topic=30427.30 and is just a db error. Unfortunately I realized this wasn't happening in the same way locally I believe because I clean installed civi so I can't test this. My guess is we installed it before this patch was applied. The currency isn't misdisplayed on the civi demo site so I think the fix is just to add a new symbol import script to wmf_install.

@mepps - so the problem is actually the data in our civicrm_currency table is messed up?

@Eileenmcnaughton yes, exactly. For example, querying the live db with SELECT * FROM civicrm_currency WHERE name='ILS'; yields:
+----+------+---------+--------------+--------------------+

idnamesymbolnumeric_codefull_name

+----+------+---------+--------------+--------------------+

5ILS₪826New Israeli Shekel

+----+------+---------+--------------+--------------------+
It is likely that UTF8 was not set before the data import when it was first set up. This was an issue around 4.4. It looks like UTF8 has since been set as the character set for the table but I also explicitly set names utf8 to make sure, so reloading the currencies should fix the issue.

Wow - I looked into that bug for a bit and absolutely did not spot that!

Ejegg triaged this task as Medium priority.Sep 12 2017, 4:56 PM
Ejegg set the point value for this task to 2.

@MBeat33 I think you had a question about testing this - we just started exporting this same symbol for use in Silverpop emails (the last donation reference). @CCogdill_WMF took a look and said they looked fine to her.

When we try to use this for a EUR donation, we get an error message:
The sum of fee amount and net amount must be equal to total amount

CID22251574.jpg (1×2 px, 374 KB)

I'm reclosing this - added a follow on task instead https://phabricator.wikimedia.org/T185045