Page MenuHomePhabricator
Create Task
Maniphest T152043

Tool Labs: Add skin, language, and variant to user_properties_anon
Closed, ResolvedPublic
Actions

Description

These were exposed in a nonanonymous fashion until recently. Removing those made sense, however for statistical analysis and metric reporting, they should remain exposed in an anonymized fashion.

For example, how many % of users use the MonoBook skin? Or how many % of users have their language preferences set to something other than English on English Wikipedia etc. These reports are periodically generated from Tool Labs, but are now broken due to their removal.

These reports never needed the user-specific information. The reports only used the user_properties table because they were absent in user_properties_anon.

See also:

In T150679#2823835, @Bawolff wrote:
In T150679#2822126, @Krinkle wrote:

Either way, does this mean we can add these two up_property values to the user_properties_anon whitelist before or after they are removed from user_properties?

Yes, I think adding skin, variant and language to user_properties_anon whitelist makes sense. I would like to not add timecorrection unless someone can come up with a persuasive use case, since that property is so much more sensitive (due to location correlation).

Details

SubjectRepoBranchLines +/-
Add skin, language, and variant to user_properties_anonoperations/puppetproduction+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Nov 30 2016, 8:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2016, 8:59 PM
Krinkle triaged this task as High priority.Nov 30 2016, 8:59 PM
Krinkle added a project: Regression.
Krinkle added subscribers: • chasemp, coren, Platonides and 2 others.
scfc moved this task from Backlog to Ready to be worked on on the Toolforge board.Dec 4 2016, 8:09 PM
Krinkle updated the task description. (Show Details)Dec 21 2016, 6:39 AM
• jcrespo mentioned this in T150679: Some Labs DB user_properties view fields are sensitive.Dec 21 2016, 5:12 PM
• bd808 subscribed.Mar 23 2017, 3:55 AM

Does anybody know how to accomplish this change to the user_properties_anon view?

gerritbot subscribed.Mar 23 2017, 4:21 AM

Change 344302 had a related patch set uploaded (by Reedy):
[operations/puppet@production] Add skin, language, and variant to user_properties_anon

https://gerrit.wikimedia.org/r/344302

gerritbot added a project: Patch-For-Review.Mar 23 2017, 4:21 AM
Reedy moved this task from Ready to be worked on to In Progress on the Toolforge board.Mar 23 2017, 4:27 AM
• bd808 moved this task from Triage to In Progress on the Cloud-Services board.Mar 26 2017, 8:13 PM
• bd808 removed a project: Toolforge.
gerritbot added a comment.Apr 3 2017, 7:32 PM

Change 344302 merged by Andrew Bogott:
[operations/puppet@production] Add skin, language, and variant to user_properties_anon

https://gerrit.wikimedia.org/r/344302

Andrew subscribed.Apr 4 2017, 12:58 AM

I merged the puppet change, but maybe this needs to be run by hand -- I've never done it.

• chasemp added a comment.Apr 6 2017, 9:45 PM
In T152043#3152818, @Andrew wrote:

I merged the puppet change, but maybe this needs to be run by hand -- I've never done it.

for now it does:

maintain-meta_p --all-databases --purge --debug

on labsdb1001/1003/1009/1010/1011

Krinkle added a comment.Apr 8 2017, 3:10 AM
In T152043#3161912, @chasemp wrote:
In T152043#3152818, @Andrew wrote:

I merged the puppet change, but maybe this needs to be run by hand -- I've never done it.

for now it does:

maintain-meta_p --all-databases --purge --debug

on labsdb1001/1003/1009/1010/1011

"It" does, what does? Does puppet automatically run this command on those particular hosts when this file changes? From what I can see neither the view on actual wiki dbs nor the meta_p.properties_anon_whitelist table was updated.

• bd808 added a comment.Apr 8 2017, 3:49 AM

"for now it does" == the script needs to be run by someone with access to labsdb1001/1003/1009/1010/1011.

Krinkle removed a project: Patch-For-Review.Apr 10 2017, 11:16 PM
Andrew closed this task as Resolved.Apr 12 2017, 3:55 PM
Andrew claimed this task.

ok, I applied https://gerrit.wikimedia.org/r/#/c/347854/ and then ran maintain-meta_p --all-databases --purge --debug on the db boxes. Should be all set.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits