Page MenuHomePhabricator
Create Task
Maniphest T152487

Rebaser: Only show cursors for connected users
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Currently you only see the cursors of all users who have joined since you, but they never go away, and new users don't appear immediately. We should hide users who have disconnected, and show all connected users.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (813c586a6)mediawiki/extensions/VisualEditormaster+1 -1
RebaseServer: Handle disconnects by setting the disconnected author's selection to nullVisualEditor/VisualEditormaster+27 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Dec 6 2016, 10:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2016, 10:07 AM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Dec 6 2016, 8:01 PM
Jdforrester-WMF triaged this task as Low priority.Dec 12 2016, 7:29 PM
Jdforrester-WMF added a parent task: T152993: Rebaser: Make VE-rebaser functionality equivalent to Etherpad.
Jdforrester-WMF set the point value for this task to 1.
gerritbot subscribed.Feb 21 2017, 10:51 AM

Change 338628 had a related patch set uploaded (by Esanders):
RebaseServer: Handle disconnects by setting the disconnected author's selection to null

https://gerrit.wikimedia.org/r/338628

gerritbot added a project: Patch-For-Review.Feb 21 2017, 10:51 AM
gerritbot added a comment.Feb 21 2017, 10:55 AM

Change 338628 merged by jenkins-bot:
RebaseServer: Handle disconnects by setting the disconnected author's selection to null

https://gerrit.wikimedia.org/r/338628

gerritbot added a comment.Feb 23 2017, 7:38 PM

Change 339481 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

gerritbot added a comment.Feb 23 2017, 8:02 PM

Change 339481 merged by jenkins-bot:
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

Jdforrester-WMF closed this task as Resolved.Feb 23 2017, 8:07 PM
Jdforrester-WMF assigned this task to Catrope.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF added a project: MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)).Mar 3 2017, 12:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits