Disable Page Previews for anons
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	phuedx
	Dec 8 2016, 2:51 PM

Description

Context

During T144490, we discovered that if the Page Previews code is delivered to an anon but the experiment is disabled, then they'll see previews. See T144490#2855170 for more detail.

AC

Previews are shown if the user is logged in and the user hasn't disabled them.

Details

Subject	Repo	Branch	Lines +/-
Hygiene: Make mw.popups#isEnabled return boolean	mediawiki/extensions/Popups	mpga	+23 -33
Hygiene: Remove experiment-related code	mediawiki/extensions/Popups	mpga	+3 -81
Redefine when Page Previews are enabled	mediawiki/extensions/Popups	mpga	+81 -144

Customize query in gerrit

Related Objects

Mentioned In: T144490: Stop Hovercards A/B tests
Mentioned Here: T146889: A preference for hovercards appears on user preferences page
T144490: Stop Hovercards A/B tests

Event Timeline

phuedx created this task.Dec 8 2016, 2:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2016, 2:51 PM

phuedx updated the task description. (Show Details)Dec 8 2016, 2:51 PM

phuedx mentioned this in T144490: Stop Hovercards A/B tests.Dec 8 2016, 5:07 PM

• bmansurov triaged this task as High priority.Dec 8 2016, 9:51 PM

• bmansurov moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

Change 327194 had a related patch set uploaded (by Phuedx):
Redefine when Page Previews are enabled

https://gerrit.wikimedia.org/r/327194

Change 327195 had a related patch set uploaded (by Phuedx):
Hygiene: Remove experiment-related code

https://gerrit.wikimedia.org/r/327195

Change 327196 had a related patch set uploaded (by Phuedx):
Hygiene: Make mw.popups#isEnabled return boolean

https://gerrit.wikimedia.org/r/327196

ovasileva added a project: Reading-Web-Sprint-87-♨️😭.Dec 14 2016, 4:12 PM

ovasileva set the point value for this task to 2.

• bmansurov added a project: Unplanned-Sprint-Work.Dec 14 2016, 4:12 PM

ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Dec 14 2016, 4:25 PM

ovasileva moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-87-♨️😭 board.Dec 14 2016, 8:55 PM

phuedx claimed this task.Dec 15 2016, 9:27 AM

Change 327194 merged by jenkins-bot:
Redefine when Page Previews are enabled

https://gerrit.wikimedia.org/r/327194

Change 327195 merged by jenkins-bot:
Hygiene: Remove experiment-related code

https://gerrit.wikimedia.org/r/327195

Change 327196 merged by jenkins-bot:
Hygiene: Make mw.popups#isEnabled return boolean

https://gerrit.wikimedia.org/r/327196

Even with all these patches merged it seems to behave incorrectly for me upon page refresh - I don't see any save to localStorage to make the option persist:

and anon...

disablepopupsanon.gif (405×809 px, 168 KB)

Given we are in rewrite status I'm a little lost at whether I'm seeing a bug or incomplete code. You may be aware of this but just pointing out just in case...

Jdlrobson moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-87-♨️😭 board.Dec 16 2016, 7:53 PM

I'll take a look on Monday. Interestingly, the acceptance tests that I've written for this part of the workflow pass. @Jhernandez: SYN.

MBinder_WMF added a project: Reading-Web-Sprint-88-¯\_(ツ)_/¯.Dec 19 2016, 5:15 PM

phuedx moved this task from Needs Analysis to Needs More Work on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Dec 19 2016, 5:19 PM

MBinder_WMF removed a project: Unplanned-Sprint-Work.Dec 19 2016, 5:21 PM

@Jdlrobson: I've tested this locally and on our staging server (which I made sure was updated).

phuedx removed phuedx as the assignee of this task.Dec 19 2016, 5:31 PM

phuedx moved this task from Needs More Work to Ready for Signoff on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.

ovasileva moved this task from Backlog to 2016-17-Q2-Goal on the Page-Previews board.Dec 19 2016, 10:50 PM

ovasileva edited projects, added Page-Previews (2016-17-Q2-Goal); removed Page-Previews.

ovasileva moved this task from Backlog to Doing on the Page-Previews (2016-17-Q2-Goal) board.Dec 20 2016, 12:31 AM

Any follow-on work will take place over at T146889: A preference for hovercards appears on user preferences page.

	F5073922: disablepopups.gif
	Dec 16 2016, 7:52 PM

	F5073958: disablepopupsanon.gif
	Dec 16 2016, 7:52 PM

Disable Page Previews for anonsClosed, ResolvedPublic2 Estimated Story PointsActions