Page MenuHomePhabricator
Create Task
Maniphest T146889

A preference for hovercards appears on user preferences page
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Sep 28 2016, 12:17 PM
Tags
Referenced Files
F4740790: Screen Shot 2016-10-27 at 2.51.42 PM.png
Nov 18 2016, 1:25 PM
F4740789: Screen Shot 2016-10-27 at 2.51.42 PM.png
Nov 18 2016, 1:25 PM
F4569793: flow.png
Oct 6 2016, 9:24 PM
F4569796: preferences.png
Oct 6 2016, 9:24 PM
Subscribers
Aklapper
• bmansurov
CKoerner_WMF
gerritbot
Jdlrobson
• Jhernandez
• jhobs
View All 13 Subscribers

Description

Story

As a logged-in user, I want the ability to turn hovercards on and off once they are in stable, so that I can see the feature when I want to

Description

Build logged-in user settings

Acceptance Criteria

Users will be able to specify whether they want hovercards on or off via a section within the user preferences page. This will contain the following:

  • The work should be done in the mpga branch.
  • Section title: Reading Preferences
  • Item title: Page Previews
  • Subtitle: Get quick previews of a topic while reading an article
  • Radio button: Enable
    • Selecting Enable and Save will turn page previews ON
    • Selecting Enable and not saving will do nothing
  • Radio button: Disable
    • Selecting Disable and Save will turn page previews OFF
    • Selecting Disable without saving will do nothing
  • Note: when hovercards are disabled for logged-in users, the “Enable Previews” link will NOT appear
  • Must be feature flagged and off until move to stable
  • Allow user settings to be inherited by beta - if user had page previews enabled in beta, enable by default
  • Order - user preference for page previews should appear immediately after "Skin"

preferences.png (692×1 px, 211 KB)

  • if I'm a logged in user, the settings cog should link to the "appearance" tab in user preferences.

flow.png (1×3 px, 1023 KB)

  • the "enable previews" link on the bottom of the page will not appear
  • this should be part of the rewrite branch

Workflow

Screen Shot 2016-10-27 at 2.51.42 PM.png (351×785 px, 33 KB)

Details

SubjectRepoBranchLines +/-
Implement necessary wiring for preferencesmediawiki/extensions/Popupsmpga+467 -129
Hygiene: Make settings reducer control footer linkmediawiki/extensions/Popupsmpga+54 -11
Send blob to everyonemediawiki/extensions/Popupsmpga+111 -61
Vary cog click behaviormediawiki/extensions/Popupsmpga+222 -33
Forward PopupsBetaFeature to the clientmediawiki/extensions/Popupsmpga+15 -4
Hygiene: Rename SchemaPopupsSamplingRatemediawiki/extensions/Popupsmpga+9 -9
Inject preference option directly after skin selectmediawiki/extensions/Popupsmpga+44 -5
ext.popups module should be loaded for anon usersmediawiki/extensions/Popupsmpga+3 -3
Introduce Opt-In option on user preferences pagemediawiki/extensions/Popupsmpga+163 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ovasileva set the point value for this task to 8.Nov 29 2016, 5:37 PM
Jdlrobson added a comment.Nov 29 2016, 5:37 PM

If necessary we can split this up into two tasks:

  1. Adding and displaying the user preference
  2. Integration - Reading and honouring the user preference.
ovasileva added a project: Reading-Web-Sprint-87-♨️😭.Nov 29 2016, 6:47 PM
• bmansurov subscribed.Dec 2 2016, 9:44 PM
In T146889#2818117, @Jdlrobson wrote:

Is this task stalled till post rewrite?

Maybe not, but we should definitely base this work on the mpga branch that was introduced for the rewrite task.

• bmansurov updated the task description. (Show Details)Dec 2 2016, 9:45 PM
MBinder_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-87-♨️😭 board.Dec 5 2016, 7:51 PM
• Tbayer subscribed.Dec 5 2016, 9:22 PM
ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Dec 7 2016, 4:07 PM
pmiazga claimed this task.Dec 8 2016, 4:54 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-87-♨️😭 board.Dec 8 2016, 5:25 PM
pmiazga updated the task description. (Show Details)Dec 13 2016, 6:33 PM
gerritbot subscribed.Dec 13 2016, 8:41 PM

Change 327041 had a related patch set uploaded (by Pmiazga):
Introduce Popups Opt-In option on user preferences page

https://gerrit.wikimedia.org/r/327041

gerritbot added a project: Patch-For-Review.Dec 13 2016, 8:41 PM
phuedx moved this task from Doing to Needs More Work on the Reading-Web-Sprint-87-♨️😭 board.Dec 14 2016, 10:46 AM
pmiazga mentioned this in T153280: WANObjectCache breaks extending $wgDefaultUserOptions via ExtensionFunctions in extensions..Dec 15 2016, 3:17 AM
pmiazga moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-87-♨️😭 board.Dec 15 2016, 6:04 PM
Jdlrobson moved this task from Code Review to Doing on the Reading-Web-Sprint-87-♨️😭 board.Dec 16 2016, 12:09 AM
Jdlrobson added a comment.Dec 16 2016, 12:11 AM

First patch is now +2ed.
Opting in exposes the following variable in JS:

mw.user.options.get('popups-enable')

So we should be able to easily check that in our logic to determining whether popups is enabled or not.

gerritbot added a comment.Dec 16 2016, 12:11 AM

Change 327041 merged by jenkins-bot:
Introduce Opt-In option on user preferences page

https://gerrit.wikimedia.org/r/327041

Jdlrobson removed a project: Patch-For-Review.Dec 16 2016, 12:12 AM
gerritbot added a comment.Dec 16 2016, 2:51 AM

Change 327696 had a related patch set uploaded (by Pmiazga):
[WIP] Implement necessary wiring for preferences

https://gerrit.wikimedia.org/r/327696

gerritbot added a project: Patch-For-Review.Dec 16 2016, 2:51 AM
pmiazga updated the task description. (Show Details)Dec 16 2016, 1:46 PM
pmiazga added a project: Reading-Web-Sprint-88-¯\_(ツ)_/¯.Dec 19 2016, 5:19 PM
pmiazga moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.
pmiazga removed a project: Reading-Web-Sprint-87-♨️😭.
ovasileva updated the task description. (Show Details)Dec 19 2016, 6:41 PM
ovasileva added subscribers: • Moushira, Ckoerner.

@ovasileva to check with @Ckoerner and @Moushira on order of preferences page

ovasileva moved this task from Backlog to Doing on the Page-Previews (2016-17-Q2-Goal) board.Dec 19 2016, 8:08 PM
pmiazga updated the task description. (Show Details)Dec 20 2016, 12:25 AM
gerritbot added a comment.Dec 20 2016, 5:19 PM

Change 327696 merged by jenkins-bot:
Implement necessary wiring for preferences

https://gerrit.wikimedia.org/r/327696

gerritbot added a comment.Dec 20 2016, 10:51 PM

Change 328430 had a related patch set uploaded (by Pmiazga):
Inject preference option directly after skin select

https://gerrit.wikimedia.org/r/328430

gerritbot added a comment.Dec 20 2016, 10:56 PM

Change 328431 had a related patch set uploaded (by Pmiazga):
ext.popups module should be loaded for anon users

https://gerrit.wikimedia.org/r/328431

pmiazga updated the task description. (Show Details)Dec 20 2016, 10:57 PM
pmiazga moved this task from Doing to Code Review on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.
phuedx subscribed.Dec 21 2016, 6:48 AM

@ovasileva: AFAICT rEPOPd6aa349536d2: Inject preference option directly after skin select moves the Reading preferences preferences immediately underneath the Skin preferences. Have we checked that this is OK?

phuedx moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Dec 21 2016, 6:48 AM
gerritbot added a comment.Dec 21 2016, 10:55 AM

Change 328431 merged by jenkins-bot:
ext.popups module should be loaded for anon users

https://gerrit.wikimedia.org/r/328431

phuedx mentioned this in T152687: Disable Page Previews for anons.Dec 21 2016, 3:13 PM
phuedx moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.
phuedx moved this task from Code Review to Doing on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.
phuedx added a comment.Dec 21 2016, 3:15 PM

The last two AC aren't met. They could be added to rEPOP14bfb67cce2e: WIP: Settings only for anons.

ovasileva added a comment.Dec 21 2016, 3:18 PM

@phuedx, @pmiazga - discussed with @Ckoerner and so long as we update the appropriate documentation before release for the main wikis, we think we're good to go with the order of the preferences (as second under skin)

phuedx added a comment.Dec 21 2016, 4:06 PM

@ovasileva: OK. Let's create a task covering updating the documentation as part of the Code Review -> Sign Off steps.

CKoerner_WMF removed a subscriber: Ckoerner.Dec 21 2016, 6:18 PM
CKoerner_WMF subscribed.
gerritbot added a comment.Dec 22 2016, 9:37 AM

Change 328430 merged by jenkins-bot:
Inject preference option directly after skin select

https://gerrit.wikimedia.org/r/328430

gerritbot added a comment.Dec 22 2016, 3:03 PM

Change 328500 had a related patch set uploaded (by Phuedx):
Send blob to everyone

https://gerrit.wikimedia.org/r/328500

gerritbot added a comment.Dec 22 2016, 3:03 PM

Change 328674 had a related patch set uploaded (by Phuedx):
Make settings reducer control footer link

https://gerrit.wikimedia.org/r/328674

gerritbot added a comment.Dec 22 2016, 3:03 PM

Change 328675 had a related patch set uploaded (by Phuedx):
Clicking cog sends user to Special:Preferences

https://gerrit.wikimedia.org/r/328675

phuedx moved this task from Doing to Code Review on the Reading-Web-Sprint-88-¯\_(ツ)_/¯ board.Dec 22 2016, 6:16 PM
phuedx added a comment.Jan 4 2017, 11:16 AM

@Jdlrobson: I've re-ordered the changes per your request.

phuedx claimed this task.Jan 4 2017, 11:32 AM
phuedx added a subscriber: pmiazga.
phuedx added a project: Reading-Web-Sprint-89-🎂.Jan 4 2017, 6:12 PM
• Tbayer added a comment.Jan 4 2017, 6:18 PM

Considering that we already track disable events (so far only from the separate dialog linked from the cards themselves) in the Popups schema, it would be good to add events there for these new enables/disables coming from the user preferences.

MBinder_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-89-🎂 board.Jan 4 2017, 11:48 PM
MBinder_WMF moved this task from To Do to Code Review on the Reading-Web-Sprint-89-🎂 board.
ovasileva added a comment.Jan 5 2017, 12:14 AM

@phuedx - created documentation task T154635: [EPIC] Deploy page previews to English and German Wikipedia - I have yet to fill in more detail

phuedx moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-89-🎂 board.Jan 5 2017, 10:18 AM
phuedx added a subscriber: • jhobs.

^ Per review from @Jdlrobson and @jhobs.

MBinder_WMF edited projects, added Page-Previews (2016-17-Q3-Goal); removed Page-Previews (2016-17-Q2-Goal).Jan 5 2017, 7:35 PM
MBinder_WMF moved this task from Backlog to Doing on the Page-Previews (2016-17-Q3-Goal) board.Jan 5 2017, 7:36 PM
MBinder_WMF moved this task from 2016-17 Q2 to 2016-17 Q3 on the Web-Team-Backlog board.Jan 9 2017, 7:39 PM
phuedx moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-89-🎂 board.Jan 15 2017, 7:51 AM

rEPOP3c5515c0b797: Vary cog click behavior, rEPOP7b9682d0059c: Send blob to everyone, and rEPOP7054a78f852f: Make settings reducer control footer link are ready to be reviewed again.

gerritbot added a comment.Jan 15 2017, 7:05 PM

Change 332151 had a related patch set uploaded (by Phuedx):
Hygiene: Rename SchemaPopupsSamplingRate

https://gerrit.wikimedia.org/r/332151

gerritbot added a comment.Jan 15 2017, 7:05 PM

Change 332152 had a related patch set uploaded (by Phuedx):
Forward PopupsBetaFeature to the client

https://gerrit.wikimedia.org/r/332152

gerritbot added a comment.Jan 15 2017, 11:38 PM

Change 332151 merged by jenkins-bot:
Hygiene: Rename SchemaPopupsSamplingRate

https://gerrit.wikimedia.org/r/332151

gerritbot added a comment.Jan 15 2017, 11:54 PM

Change 332152 merged by jenkins-bot:
Forward PopupsBetaFeature to the client

https://gerrit.wikimedia.org/r/332152

gerritbot added a comment.Jan 16 2017, 12:31 AM

Change 328675 merged by jenkins-bot:
Vary cog click behavior

https://gerrit.wikimedia.org/r/328675

• Jhernandez moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-89-🎂 board.Jan 16 2017, 1:02 AM
• Jhernandez subscribed.

cc @phuedx

MBinder_WMF moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-89-🎂 board.Jan 17 2017, 6:02 PM
gerritbot added a comment.Jan 17 2017, 7:08 PM

Change 328500 merged by jenkins-bot:
Send blob to everyone

https://gerrit.wikimedia.org/r/328500

gerritbot added a comment.Jan 17 2017, 7:08 PM

Change 328674 merged by jenkins-bot:
Hygiene: Make settings reducer control footer link

https://gerrit.wikimedia.org/r/328674

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-89-🎂 board.Jan 17 2017, 7:25 PM
phuedx removed phuedx as the assignee of this task.Jan 17 2017, 9:26 PM
ovasileva closed this task as Resolved.Jan 18 2017, 1:33 AM
ovasileva claimed this task.

tested, all done! Good job everyone!

phuedx added a comment.Jan 18 2017, 1:50 AM

For the record, this is available to test here: http://reading-web-staging.wmflabs.org.

• Nirzar added a comment.Jan 18 2017, 6:59 AM

The tip text is appearing on left and a unreadable font size, can we match the alignment and fontsize with zeplin spec?

• Nirzar added a comment.Jan 18 2017, 7:01 AM

@ovasileva can we re-open please?

ovasileva added a comment.Jan 18 2017, 8:42 PM

@Nirzar - do we still need to reopen or can this also be tracked under a separate task?

• Nirzar added a comment.Jan 18 2017, 9:30 PM

I will create another task

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits