Page MenuHomePhabricator
Create Task
Maniphest T153347

Block cookies should expire after 24 hours or the length of the actual block, whichever is shorter
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Let's change the cookie expiration to expire after 24 hours or the length of the actual block, whichever is shorter (at least until we're sure that it's not causing any problems). (Hopefully, this is the same way that non-cookie autoblocks currently work.)

Details

SubjectRepoBranchLines +/-
Default block-cookies to 24 hours onlymediawiki/coremaster+20 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

kaldari created this task.Dec 15 2016, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2016, 6:50 PM
kaldari triaged this task as Medium priority.Dec 15 2016, 6:50 PM
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.
kaldari set the point value for this task to 1.
kaldari moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
kaldari added a parent task: T152953: $wgCookieSetOnAutoblock should perhaps spread autoblocks when the cookie matches.Dec 15 2016, 6:56 PM
Samwilson claimed this task.Dec 19 2016, 4:49 AM
Samwilson edited projects, added Community-Tech-Sprint; removed Community-Tech.
gerritbot subscribed.Dec 20 2016, 12:10 PM

Change 328353 had a related patch set uploaded (by Samwilson):
Default block-cookies to 24 hours only

https://gerrit.wikimedia.org/r/328353

gerritbot added a project: Patch-For-Review.Dec 20 2016, 12:10 PM
Samwilson moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.Dec 21 2016, 1:07 AM
kaldari closed this task as Resolved.Dec 22 2016, 2:15 AM
kaldari moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.
gerritbot added a comment.Dec 22 2016, 2:22 AM

Change 328353 merged by jenkins-bot:
Default block-cookies to 24 hours only

https://gerrit.wikimedia.org/r/328353

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), MW-1.29-release-notes.Dec 22 2016, 3:00 AM
• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Jan 3 2017, 7:42 PM
• DannyH moved this task from Up Next (June 3-21) to Archive on the Community-Tech board.Jan 3 2017, 7:44 PM
• DannyH added a parent task: T5233: Send a cookie with each block.Jan 30 2017, 7:24 PM
Tchanders mentioned this in T233595: Clear block cookie when tracking block, not when checking block.Oct 9 2019, 10:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits