Page MenuHomePhabricator
Create Task
Maniphest T153799

Handle old-style MPs
Closed, ResolvedPublic
Actions

Description

ClearTables doesn't currently handle old-style multipolygons, and it needs to.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT87268 Copyright license and attribution issues (tracking)
 InvalidNoneT149179 Attribution and copyright tasks for the iOS app (tracking)
 OpenFeatureNoneT157763 Replace Apple Maps with a freely licensed alternative
InvalidNoneT155601 Stabilizing Interactive Products
 OpenNoneT113008 Epic: Borders aren't always marked as disputed
 ResolvedPnormanT153282 [epic] Migrate to a new vector tile structure
 DeclinedNoneT153286 Switch to brighmed map style
 DeclinedNoneT153287 Switch to meddo vector tiles
 DeclinedNoneT153283 Migrate osm2pgsql to ClearTables structure
 ResolvedPnormanT153799 Handle old-style MPs
 ResolvedPnormanT153400 Implement all osm-bright.tm2 features in brighmed
 ResolvedPnormanT153404 Implement all osm-bright.tm2source features in meddo
 ResolvedPnormanT154818 Add transportation POIs
 ResolvedPnormanT154819 Add piers to land
 ResolvedPnormanT154820 Add schools
 ResolvedPnormanT154821 Add hospitals
 ResolvedPnormanT155199 Use Natural Earth for low-zoom cities
 ResolvedPnormanT155279 Implement road shields
 ResolvedPnormanT156204 Add airport features
 ResolvedPnormanT156336 Treat botanical gardens like parks
 ResolvedPnormanT163515 Treat national forests like national parks
 ResolvedPnormanT167724 Include name in transit stops
 ResolvedPnormanT154823 Style tunnels differently
 DuplicateNoneT154824 Add suburbs
 ResolvedPnormanT154828 Add neighborhoods
ResolvedNoneT154832 Add neighborhoods to meddo
 ResolvedPnormanT154822 Add parks to Brighmed
 ResolvedPnormanT154834 Add parks to meddo
 ResolvedPnormanT154835 Add parks to ClearTables
 ResolvedPnormanT155474 Pick source for icons
 ResolvedPnormanT156327 Strengthen z12-z13 medium roads
 ResolvedPnormanT156328 Fix incorrect road ordering
 ResolveddebtT156335 Decide on graveyards
 ResolvedPnormanT158353 Add/test country labels
 ResolvedPnormanT168906 Style transit stop names
 ResolvedNoneT154827 Remove high zoom city dots
 ResolvedPnormanT156542 Make parks visible one zoom earlier
 ResolvedPnormanT155207 Reduce visual weight of bridges in brighmed
 ResolvedPnormanT160046 Word-wrap place labels
 ResolvedPnormanT160047 Add partial index for low-zoom roads
 ResolvedPnormanT160049 Investigate city label priority
 ResolvedPnormanT162764 Copy font list from osm-carto
 ResolvedPnormanT163491 Scale country labels based on area
 ResolvedPnormanT163503 Decide on city/region label priorities
 DeclinedPnormanT163809 Review buildings over water
 ResolvedPnormanT163811 Decide on transit stop vs place label priority
 DeclinedPnormanT163812 Add transit stop label text
 ResolvedPnormanT164811 Look at major and medium bridge styling
 ResolvedPnormanT167914 Minor roads are appearing on z12
 ResolvedPnormanT172341 Sort water areas by size when labeling

Event Timeline

Pnorman created this task.Dec 20 2016, 9:56 PM
Pnorman added a comment.Dec 20 2016, 10:00 PM

Probably going to resolve this in common with OpenStreetMap Carto https://github.com/gravitystorm/openstreetmap-carto/issues/1504#issuecomment-265933958 to use common code, common tests, and get more eyes on the problem. ClearTables is easier to unit test, requires more mocks to test this functionality, and has few eyes reviewing it. OSM Carto is harder to unit test, doesn't require mocks, and has more visibility.

Pnorman added a comment.Jan 9 2017, 11:51 PM

ref https://github.com/gravitystorm/openstreetmap-carto/pull/2533.

I've had private favorable feedback on the definitions I intend to use

Pnorman closed this task as Resolved.Jun 12 2017, 7:51 PM

OpenStreetMap Carto no longer supports old-style MPs in version 4, so I've done the same with ClearTables. I'm resolving this as resolved instead of declined because the desire was to have old-style MPs handled like other software, and it was done when those expectations changed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits