Page MenuHomePhabricator
Create Task
Maniphest T153805

Add wikidata ID to ClearTables
Closed, ResolvedPublic
Actions

Description

https://github.com/ClearTables/ClearTables/issues/70 documents the ClearTables side of what needs doing

One question is if we want to handle the case of an OSM object having multiple Wikidata IDs. Wikidata IRIs have a many to many relationship with OSM features, but in practice very few features have multiple IDs tagged. My inclination is to only handle the common case of one wikidata ID.

The other question is what datatype to use for an ID. I can't find any information if we need a 32-bit number, 64-bit number, or numeric type with no maximum size.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT87268 Copyright license and attribution issues (tracking)
 InvalidNoneT149179 Attribution and copyright tasks for the iOS app (tracking)
 OpenFeatureNoneT157763 Replace Apple Maps with a freely licensed alternative
InvalidNoneT155601 Stabilizing Interactive Products
 OpenNoneT113008 Epic: Borders aren't always marked as disputed
 ResolvedPnormanT153282 [epic] Migrate to a new vector tile structure
 DeclinedNoneT153286 Switch to brighmed map style
 DeclinedNoneT153287 Switch to meddo vector tiles
 DeclinedNoneT153283 Migrate osm2pgsql to ClearTables structure
 ResolvedPnormanT153805 Add wikidata ID to ClearTables
 ResolvedPnormanT153400 Implement all osm-bright.tm2 features in brighmed
 ResolvedPnormanT153404 Implement all osm-bright.tm2source features in meddo
 ResolvedPnormanT154818 Add transportation POIs
 ResolvedPnormanT154819 Add piers to land
 ResolvedPnormanT154820 Add schools
 ResolvedPnormanT154821 Add hospitals
 ResolvedPnormanT155199 Use Natural Earth for low-zoom cities
 ResolvedPnormanT155279 Implement road shields
 ResolvedPnormanT156204 Add airport features
 ResolvedPnormanT156336 Treat botanical gardens like parks
 ResolvedPnormanT163515 Treat national forests like national parks
 ResolvedPnormanT167724 Include name in transit stops
 ResolvedPnormanT154823 Style tunnels differently
 DuplicateNoneT154824 Add suburbs
 ResolvedPnormanT154828 Add neighborhoods
ResolvedNoneT154832 Add neighborhoods to meddo
 ResolvedPnormanT154822 Add parks to Brighmed
 ResolvedPnormanT154834 Add parks to meddo
 ResolvedPnormanT154835 Add parks to ClearTables
 ResolvedPnormanT155474 Pick source for icons
 ResolvedPnormanT156327 Strengthen z12-z13 medium roads
 ResolvedPnormanT156328 Fix incorrect road ordering
 ResolveddebtT156335 Decide on graveyards
 ResolvedPnormanT158353 Add/test country labels
 ResolvedPnormanT168906 Style transit stop names
 ResolvedNoneT154827 Remove high zoom city dots
 ResolvedPnormanT156542 Make parks visible one zoom earlier
 ResolvedPnormanT155207 Reduce visual weight of bridges in brighmed
 ResolvedPnormanT160046 Word-wrap place labels
 ResolvedPnormanT160047 Add partial index for low-zoom roads
 ResolvedPnormanT160049 Investigate city label priority
 ResolvedPnormanT162764 Copy font list from osm-carto
 ResolvedPnormanT163491 Scale country labels based on area
 ResolvedPnormanT163503 Decide on city/region label priorities
 DeclinedPnormanT163809 Review buildings over water
 ResolvedPnormanT163811 Decide on transit stop vs place label priority
 DeclinedPnormanT163812 Add transit stop label text
 ResolvedPnormanT164811 Look at major and medium bridge styling
 ResolvedPnormanT167914 Minor roads are appearing on z12
 ResolvedPnormanT172341 Sort water areas by size when labeling

Event Timeline

Pnorman created this task.Dec 20 2016, 11:40 PM
Yurik added a comment.Dec 20 2016, 11:51 PM

I'm sure 64bit would be safer. Wikidata uses autonumber

Pnorman added a comment.Dec 20 2016, 11:59 PM

autonumber?

Yurik added a comment.Dec 21 2016, 12:04 AM

It started at 1 and increments sequentially, so 64bit should be safe

Pnorman added a comment.Feb 17 2017, 6:36 AM

Summary of discussion today

  • Fixing bugs with other relation types is out of scope for this
  • Doing a UNION ALL of the other cleartables tables would miss objects not in ClearTables and potentially have duplicates
  • Additional tables can be added in the WMF fork that gets deployed, since it's out of scope for ClearTables, and also isn't required for rendering.
  • polygon vs line is required in the database
  • These tables will be a table for points, lines, and polygons, with osm_id, geometry, and wikidata ID. An index will be needed for wikidata ID, but the default geom index is not required. Points is not strictly required at the moment, but trivial to implement with the other work done
Pnorman added a comment.May 12 2017, 8:14 PM

Done in its own branch and tagged releases, serving both as what we need and an example of how to extend ClearTables

Gehel unsubscribed.Jun 20 2017, 1:33 PM
Pnorman closed this task as Resolved.Oct 11 2017, 12:02 AM
Pnorman claimed this task.

Completed some time ago.

debt added a project: Maps-Sprint.Oct 11 2017, 12:09 AM
debt moved this task from Backlog to Done on the Maps-Sprint board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits