Access level to Wikibase\Repo\Diff\EntityContentDiffView::getRevisionHeader() must be public
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	thcipriani
	Jan 4 2017, 8:10 PM

Description

Just deployed 1.29.0-wmf.7 to group1 wikis and seeing this error quite a bit

Fatal error: Access level to Wikibase\Repo\Diff\EntityContentDiffView::getRevisionHeader() must be public (as in class DifferenceEngine) or weaker in /srv/mediawiki/php-1.29.0-wmf.7/extensions/Wikidata/extensions/Wikibase/repo/includes/Diff/EntityContentDiffView.php on line 36

Details

Subject	Repo	Branch	Lines +/-
Change Wikidata target branch	mediawiki/core	wmf/1.29.0-wmf.7	+2 -2
New build	mediawiki/extensions/Wikidata	wmf/1.29.0-wmf.5.1	+102 -102
Make EntityContentDiffView::getRevisionHeader public	mediawiki/extensions/Wikibase	wmf/1.29.0-wmf.5.1	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMWc40fbea783da: Make DifferenceEngine's markPatrolledLink and getRevisionHeader public so that…

Event Timeline

thcipriani created this task.Jan 4 2017, 8:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2017, 8:10 PM

Caused by c40fbea783da5f7a302da0ff05fcab81db79afe9

matmarex added a subscriber: ashley.Jan 4 2017, 8:15 PM

zhuyifei1999 subscribed.Jan 4 2017, 8:19 PM

Addshore claimed this task.Jan 4 2017, 8:24 PM

Addshore triaged this task as High priority.

Addshore added a project: WMDE-TechWish.

Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 4 2017, 8:24 PM

Change 330468 had a related patch set uploaded (by Addshore):
Make EntityContentDiffView::getRevisionHeader public

https://gerrit.wikimedia.org/r/330468

gerritbot added a project: Patch-For-Review.Jan 4 2017, 8:36 PM

Change 330468 merged by jenkins-bot:
Make EntityContentDiffView::getRevisionHeader public

https://gerrit.wikimedia.org/r/330468

Change 330479 had a related patch set uploaded (by Addshore):
New build

https://gerrit.wikimedia.org/r/330479

Once the above patch / new build has been merged wmf7 and Wikidata wmf5.1 should work together.

a 5.1 branch was created to keep core wmf5 and wikidata / wikibase wmf5 compatible with each other.
wmf6 and wmf7 were not used as they already include many other changes.
wmf5.1 of wikibase / wikidata allows a minimal change / update.

Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.Jan 4 2017, 9:20 PM

Addshore moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.

Change 330479 merged by jenkins-bot:
New build

https://gerrit.wikimedia.org/r/330479

matmarex unsubscribed.Jan 4 2017, 9:38 PM

Change 330590 had a related patch set uploaded (by Thcipriani):
Change Wikidata target branch

https://gerrit.wikimedia.org/r/330590

Change 330590 merged by jenkins-bot:
Change Wikidata target branch

https://gerrit.wikimedia.org/r/330590

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Jan 5 2017, 12:01 AM

Addshore closed this task as Resolved.Jan 6 2017, 2:23 PM

Addshore moved this task from Currently in sprint to Done on the WMDE-TechWish board.

Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Jan 23 2017, 11:27 AM

Addshore moved this task from Done to Demoed on the WMDE-TechWish board.Jan 24 2017, 1:26 PM

Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:01 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM

Access level to Wikibase\Repo\Diff\EntityContentDiffView::getRevisionHeader() must be publicClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

Access level to Wikibase\Repo\Diff\EntityContentDiffView::getRevisionHeader() must be public
Closed, ResolvedPublicPRODUCTION ERROR
Actions