Review 2FA login on iOS app
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JMinor
	Jan 5 2017, 7:59 PM

Description

Project Information

Name of tool/project: iOS app 2FA support
Project home page: T150699
Name of team requesting review: iOS app
Primary contact: @JMinor
Target date for deployment: 3/16(ish)
Link to code repository / patchset: https://github.com/wikimedia/wikipedia-ios
Programming Language(s) Used: Swift, Javacript/HTML
Link to development setup instructions: https://github.com/wikimedia/wikipedia-ios/blob/develop/README.md

Description of the tool/project

Adding support for 2 factor users to the iOS app

Description of how the tool will be used at WMF

Used by end users

Dependencies

All the upstream dependencies are complete (see parent tickets of T150699)

Has this project been reviewed before?

please link to tasks or wiki pages of previous reviews
This is a subpart of 2FA support, so the project as a whole has been reviewed, although this implementation is new.

Working test environment

For building/running from source we will need to set you up with iOS dev toolchain. To blackbox test, we can add you to a special test build which you can install on any iOS device to test.

Post-deployment

iOS app team, @JMinor is the product owner, @Mhurd is the technical owner

Related Objects

Mentioned In: E503: Security review of 2FA login on iOS app
Mentioned Here: T150699: [iOS] Allow users to log in with 2FA in the app

Event Timeline

• JMinor created this task.Jan 5 2017, 7:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2017, 7:59 PM

• JMinor added a project: Wikipedia-iOS-App-Backlog (Administrative).Jan 5 2017, 7:59 PM

• JMinor moved this task from Administrative to Tracking on the Wikipedia-iOS-App-Backlog board.Jan 19 2017, 8:15 PM

• JMinor edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (Administrative).

@JMinor, this review has been scheduled for the week of March 13th. Does this work for your deployment schedule? Also, can you provide documentation of setting up a test environment?

• dpatrick moved this task from Incoming to Scheduled on the deprecated-security-team-reviews board.Feb 22 2017, 7:08 PM

@dpatrick This will be towards the end of the release cycle but we will make it work.

@Mhurd and @ABorbaWMF have been working on testing setup and steps, so we should be able to provide those shortly. One complication here is that you'll need a special build that points to the beta cluster, since you need a user with bureaucrat permissions to perform some tests.

• JMinor updated the task description. (Show Details)Mar 8 2017, 12:14 AM

@dpatrick We should be all set for your review next week as all the 2FA work should be complete by the end of this week and merged into the test app. Please let me know here or by email who we should add to the TestFlight system so they can receive test builds (names and emails).

Also let me know if you want to set up a quick meeting to discuss test environment, etc.

@JMinor, I just rescheduled this for this week and next. I'll contact you off-Phab to schedule a review commencement meeting.

• JMinor updated the task description. (Show Details)Mar 23 2017, 5:47 PM

• JMinor updated the task description. (Show Details)