Page MenuHomePhabricator
Create Task
Maniphest T154779

Upload file " bad-prefix" error appears and block upload
Closed, ResolvedPublic
Actions

Description

Hello,
When using the new Upload Wizard, the automatic step of checking "bad file names" occures.
This checking step was before at the step/tab "Describe", and is now at the step/tab "Upload".

I get the message « bad-prefix : IMG_5389.jpg » each time. (screenshot : https://i.snag.gy/IDBUpO.jpg )

IDBUpO.png (508×986 px, 110 KB)

Before, it was possible to change the name of the file in the text fields, now that this checking is in the first upload step, they're is no other possibility than cancel, change the file name on computer, and restart the upload.

This error obviously doesn't appears with the old upload form, and neither with a file already changed to "correctname.jpg".

I am using the french Upload Wizard (and I have another issue trying with english language selected).

Thanks !

Details

SubjectRepoBranchLines +/-
Ignore 'bad-prefix' warning on the Upload stepmediawiki/extensions/UploadWizardwmf/1.29.0-wmf.7+1 -0
Ignore 'bad-prefix' warning on the Upload stepmediawiki/extensions/UploadWizardmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Roumpf created this task.Jan 6 2017, 4:31 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 6 2017, 4:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• jcrespo closed this task as a duplicate of T154780: Cache and media (images) issues on all Wikimedia wikis - creates problems on upload, display and generation of thumbnails and files.Jan 6 2017, 6:08 PM
matmarex updated the task description. (Show Details)Jan 6 2017, 6:10 PM
matmarex reopened this task as Open.EditedJan 6 2017, 6:12 PM
matmarex added subscribers: • jcrespo, matmarex.

I don't think this is the same issue. We've changed how various error messages are generated recently, this might be a regression.

matmarex added a comment.Jan 6 2017, 7:09 PM

I actually have no idea why this has started to happen now. It's caused by some change in MediaWiki core, not UploadWizard – I get the same error when testing current MediaWiki with an older UploadWizard version. But we should fix it in UW.

gerritbot subscribed.Jan 6 2017, 7:10 PM

Change 330974 had a related patch set uploaded (by Bartosz Dziewoński):
Ignore 'bad-prefix' warning on the Upload step

https://gerrit.wikimedia.org/r/330974

gerritbot added a project: Patch-For-Review.Jan 6 2017, 7:10 PM
matmarex triaged this task as Unbreak Now! priority.Jan 6 2017, 7:12 PM

Looking at UW's logs, this is affecting a huge number of uploads, causing as many UW upload failures as all legitimate errors counted together.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJan 6 2017, 7:12 PM
Paladox subscribed.Jan 6 2017, 7:14 PM
gerritbot added a comment.Jan 6 2017, 7:18 PM

Change 330974 merged by jenkins-bot:
Ignore 'bad-prefix' warning on the Upload step

https://gerrit.wikimedia.org/r/330974

gerritbot added a comment.Jan 6 2017, 7:18 PM

Change 330975 had a related patch set uploaded (by Bartosz Dziewoński):
Ignore 'bad-prefix' warning on the Upload step

https://gerrit.wikimedia.org/r/330975

gerritbot added a comment.Jan 6 2017, 7:21 PM

Change 330975 merged by jenkins-bot:
Ignore 'bad-prefix' warning on the Upload step

https://gerrit.wikimedia.org/r/330975

matmarex closed this task as Resolved.Jan 6 2017, 7:42 PM
matmarex claimed this task.
matmarex edited projects, added MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)); removed Patch-For-Review.
matmarex added a subscriber: • demon.

Fixed, and deployed by @demon.

matmarex added a comment.Jan 6 2017, 7:47 PM

I tracked down the root cause – this was actually caused by a change in UploadWizard: {8a6b6a49b3fe5e49bced9ed9ca847c18acfb0dce} (https://gerrit.wikimedia.org/r/#/c/327263/). Prior to that, we were prepending current timestamp to the file name before uploading, which was changed to work better with AbuseFilter. This prepended prefix meant that we never hit the real prefix checks, and the code to handle this warning was missing.

Roumpf added a comment.Jan 6 2017, 9:15 PM

Thanks !

Thibaut120094 awarded a token.Jan 6 2017, 9:21 PM
Thibaut120094 subscribed.

Thank you

matmarex mentioned this in T155039: Files named with cyrillic characters rejected with "The filename is too short." on Upload step.Jan 10 2017, 7:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits