We should phase out the Jenkins jobs:
erblint-HEAD
pplint-HEAD
Can be replaced by a rake task such as operations/puppet rake task puppetlint_head.
Challenge is to figure out how to lint then from pure ruby :]
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T154894 Phase out jobs "pplint-HEAD" and "erblint-HEAD" | |||
| Resolved | hashar | T154915 Get rid of "import realm.pp" in manifests/site.pp |
Change 331239 had a related patch set uploaded (by Hashar):
(WIP) puppet parse from rake (WIP)
Change 331309 had a related patch set uploaded (by Hashar):
Add experimental rake-jessie to puppet modules
Change 331312 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 331327 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 331328 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 331329 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 331330 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 331332 had a related patch set uploaded (by Hashar):
Introduce linters using rake
I got patch for puppet.git and some of the submodules. Sent an announce to the internal ops list to gather feedback. If https://gerrit.wikimedia.org/r/#/c/331239/ gets consensus and get merged, we can phase out pplint-HEAD and erblint-HEAD from operations/puppet. Then migrate other repositories that might use that and finally delete the jobs.
Change 335815 had a related patch set uploaded (by Hashar):
Make some puppet submodule rake jobs voting
Luca and I have sprinted a review of all changes and they are now merged in the submodules projects.
In Gerrit I have made the operations/puppet/.* sub repos to inherit rights from a new repository operations/puppet-modules.
Then I have granted rights to jenkins so it can submit changes https://gerrit.wikimedia.org/r/#/admin/projects/operations/puppet-modules,access
This way you can just CR+2 and Jenkins will merge the subproject change for you if 'bundle exec rake test' pass.
Jenkins bot CAN NOT submit to operations/puppet.
What is left to be done:
The equivalent for the mariadb module, but that touches databases:
https://gerrit.wikimedia.org/r/#/c/331329/
Bump the submodules in operations/puppet , deploy, verify etc.
Then operations/puppet https://gerrit.wikimedia.org/r/#/c/331239/ can be rebased and 'bundle exec rake test' should work even with submodules checked out :-}
Change 337028 had a related patch set uploaded (by Hashar):
[operations/puppet/mariadb] switch to rake
Change 337858 had a related patch set uploaded (by Hashar):
Use puppet-syntax gem for syntax checking
Change 338143 had a related patch set uploaded (by Hashar):
syntax: ignore stdlib Puppet 4 manifests
Change 338369 had a related patch set uploaded (by Hashar):
operations/puppet: drop erblint-HEAD/pplint-HEAD
Change 338369 merged by jenkins-bot:
operations/puppet: drop erblint-HEAD/pplint-HEAD
Change 338378 had a related patch set uploaded (by Hashar):
Switch remaining puppet modules to rake
Change 338384 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 338385 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 338386 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 338387 had a related patch set uploaded (by Hashar):
Introduce linters using rake
Change 338415 had a related patch set uploaded (by Hashar):
Use puppet-syntax gem for syntax checking
Change 338724 had a related patch set uploaded (by Hashar):
[mediawiki/vagrant] drop erblint-HEAD
Change 338725 had a related patch set uploaded (by Hashar):
Remove erblint-HEAD and pplint-HEAD
Change 339249 had a related patch set uploaded (by Hashar):
mediawiki/vagrant: remove erblint-HEAD
Mentioned in SAL (#wikimedia-releng) [2017-02-22T20:54:18Z] <hashar> Deleted jenkins job erblint-HEAD. Fully replaced by rake / puppet-syntax gem - T154894
Change 338724 abandoned by Hashar:
[mediawiki/vagrant] drop erblint-HEAD
Reason:
Duplicate /done
Change 338725 abandoned by Hashar:
Remove erblint-HEAD and pplint-HEAD
Reason:
Duplicate /done
Mentioned in SAL (#wikimedia-releng) [2017-02-22T20:58:57Z] <hashar> Deleted jenkins job pplint-HEAD. Fully replaced by rake / puppet-syntax gem - T154894
Change 338386 merged by Hashar:
[operations/puppet/nginx] Introduce linters using rake
Change 338387 merged by Hashar:
[operations/puppet/wikimetrics] Introduce linters using rake
Change 338384 merged by Ottomata:
[operations/puppet/cdh4@master] Introduce linters using rake
Change 338385 merged by Ottomata:
[operations/puppet/kafka@master] Introduce linters using rake