Page MenuHomePhabricator
Create Task
Maniphest T154915

Get rid of "import realm.pp" in manifests/site.pp
Closed, ResolvedPublic
Actions

Description

Our operations/puppet.git manifests/site.pp still has a puppet import statement which is deprecated. Hence puppet parser validate complains with:

Warning: The use of 'import' is deprecated at operations/puppet/manifests/site.pp:9
See:

manifests/site.pp
# site.pp

import 'realm.pp' # These ones first

After all the roles have been moved to modules/role, that is the last import statement to get rid of.

Details

SubjectRepoBranchLines +/-
test: puppet-syntax now fails on deprecation noticesoperations/puppetproduction+0 -3
Test the future parser in puppet compileroperations/puppetproduction+2 -4
puppet parse validate from rakeoperations/puppetproduction+31 -53
Customize query in gerrit

Revisions and Commits

rOPUP Wikimedia Puppet
rOPUP34dd79742cef site.pp: remove import of realm.pp

Related Objects
Search...

Event Timeline

hashar created this task.Jan 9 2017, 6:11 PM
hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.
gerritbot subscribed.Jan 10 2017, 10:17 AM

Change 331239 had a related patch set uploaded (by Hashar):
puppet parse validate from rake

https://gerrit.wikimedia.org/r/331239

gerritbot added a project: Patch-For-Review.Jan 10 2017, 10:17 AM
hashar removed a project: Patch-For-Review.Jan 10 2017, 10:40 AM
gerritbot added a comment.Jan 19 2017, 4:30 PM

Change 333012 had a related patch set uploaded (by Hashar):
test: puppet-syntax now fails on deprecation notices

https://gerrit.wikimedia.org/r/333012

gerritbot added a project: Patch-For-Review.Jan 19 2017, 4:30 PM
hashar removed a project: Patch-For-Review.Jan 19 2017, 4:31 PM
hashar updated the task description. (Show Details)
hashar updated the task description. (Show Details)
gerritbot added a comment.Feb 16 2017, 5:11 PM

Change 331239 merged by Jcrespo:
puppet parse validate from rake

https://gerrit.wikimedia.org/r/331239

Ottomata triaged this task as Medium priority.Mar 6 2017, 7:19 PM
hashar updated the task description. (Show Details)Jun 16 2017, 9:14 AM
hashar updated the task description. (Show Details)Jun 16 2017, 9:17 AM
hashar added a project: Release-Engineering-Team.Jun 16 2017, 9:24 AM

I have poked the ops mailing list about it.

gerritbot added a comment.Jun 16 2017, 10:24 AM

Change 322898 had a related patch set uploaded (by Hashar; owner: Alexandros Kosiaris):
[operations/puppet@production] Test the future parser in puppet compiler

https://gerrit.wikimedia.org/r/322898

gerritbot added a project: Patch-For-Review.Jun 16 2017, 10:24 AM
Paladox subscribed.Jun 16 2017, 10:26 AM
greg moved this task from INBOX to Watching / External on the Release-Engineering-Team board.Jul 6 2017, 7:01 PM
greg edited projects, added Release-Engineering-Team (Watching / External); removed Release-Engineering-Team.
hashar claimed this task.Dec 18 2017, 3:46 PM
Restricted Application edited projects, added Release-Engineering-Team (Kanban); removed Release-Engineering-Team (Watching / External). · View Herald TranscriptDec 18 2017, 3:46 PM
hashar added a commit: rOPUP34dd79742cef: site.pp: remove import of realm.pp.Dec 18 2017, 3:47 PM
hashar updated the task description. (Show Details)
hashar moved this task from Backlog to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
hashar added a subscriber: Joe.
hashar added a comment.Jan 8 2018, 9:28 AM

Pending https://gerrit.wikimedia.org/r/#/c/333012/ to have puppet-syntax to fail on deprecation notices

gerritbot added a comment.Jan 26 2018, 6:36 PM

Change 322898 abandoned by Alexandros Kosiaris:
Test the future parser in puppet compiler

Reason:
No longer required

https://gerrit.wikimedia.org/r/322898

hashar changed the task status from Open to Stalled.Jan 31 2018, 8:13 PM
hashar removed hashar as the assignee of this task.

Pending https://gerrit.wikimedia.org/r/#/c/333012/ to have puppet-syntax to fail on deprecation notices

herron mentioned this in T184564: Plan Puppet 5 upgrade.Apr 4 2018, 7:03 PM
herron subscribed.May 2 2018, 5:24 PM
herron mentioned this in T193664: Knock down puppet 4 deprecation warnings.May 2 2018, 6:13 PM
gerritbot added a comment.Aug 27 2018, 1:40 PM

Change 333012 abandoned by Hashar:
test: puppet-syntax now fails on deprecation notices

Reason:
Obsolete.

https://gerrit.wikimedia.org/r/333012

dduvall subscribed.Oct 22 2018, 4:42 PM

@hashar, this is marked as "Done" in RelEng Kanban. Any update?

gerritbot added a comment.Oct 29 2018, 12:46 PM

Change 333012 restored by Hashar:
test: puppet-syntax now fails on deprecation notices

https://gerrit.wikimedia.org/r/333012

hashar changed the task status from Stalled to Open.Oct 29 2018, 12:48 PM

The reason for this task is to have PuppetSyntax to whine on a deprecated features. The last one was an import 'realm.pp' which has been removed in November 2017 by 34dd79742cef0c168cb8aaf61f143cb052b1c1f2

I have restored my patch https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/333012/

We also need to cleanup any references to realm.pp, notably the file is still in the repository.

gerritbot added a comment.Jan 10 2019, 4:51 PM

Change 333012 merged by Alexandros Kosiaris:
[operations/puppet@production] test: puppet-syntax now fails on deprecation notices

https://gerrit.wikimedia.org/r/333012

hashar closed this task as Resolved.Jan 11 2019, 7:29 AM
hashar claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits