Page MenuHomePhabricator
Create Task
Maniphest T155682

Unable do create any page in Index namespace of wikisources
Closed, ResolvedPublic
Actions

Description

Attempt to create new page in Index: namespace in any wikisource gives an internal error:

Internal error
[WH-uVApAMEgAAIpZq2oAAAAO] 2017-01-18 22:38:12: Fatal exception of type "BadMethodCallException"

This worked few hours ago.

Creating new index pages is a critical activity in Wikisource.

Details

SubjectRepoBranchLines +/-
Revert "Use the parser to get each template parameter in the Index: namespace"mediawiki/extensions/ProofreadPagewmf/1.29.0-wmf.8+3 -16
Revert "Use the parser to get each template parameter in the Index: namespace"mediawiki/extensions/ProofreadPagemaster+3 -16
Customize query in gerrit

Related Objects

Event Timeline

Ankry created this task.Jan 18 2017, 10:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2017, 10:43 PM
Ankry updated the task description. (Show Details)Jan 18 2017, 10:43 PM
Wieralee subscribed.Jan 18 2017, 10:44 PM
Legoktm triaged this task as Unbreak Now! priority.Jan 18 2017, 10:45 PM
Legoktm subscribed.
2017-01-18 22:38:12 [WH-uVApAMEgAAIpZq2oAAAAO] mw1237 sourceswiki 1.29.0-wmf.8 exception ERROR: [WH-uVApAMEgAAIpZq2oAAAAO] /w/index.php?title=Index:Wielka_bitwa_narod%C3%B3w._Blokhauz_pod_Syren%C4%85_(cz._1).djvu&action=edit   BadMethodCallException from line 250 of /srv/mediawiki/php-1.29.0-wmf.8/extensions/ProofreadPage/includes/index/ProofreadIndexPage.php: Call to a member function getChildrenOfType() on a non-object (boolean) {"exception_id":"WH-uVApAMEgAAIpZq2oAAAAO","caught_by":"mwe_handler"} 
[Exception BadMethodCallException] (/srv/mediawiki/php-1.29.0-wmf.8/extensions/ProofreadPage/includes/index/ProofreadIndexPage.php:250) Call to a member function getChildrenOfType() on a non-object (boolean)
  #0 /srv/mediawiki/php-1.29.0-wmf.8/extensions/ProofreadPage/includes/index/EditProofreadIndexPage.php(41): ProofreadIndexPage->getIndexEntries()
  #1 /srv/mediawiki/php-1.29.0-wmf.8/includes/EditPage.php(2777): EditProofreadIndexPage->showContentForm()
  #2 /srv/mediawiki/php-1.29.0-wmf.8/includes/EditPage.php(639): EditPage->showEditForm()
  #3 /srv/mediawiki/php-1.29.0-wmf.8/extensions/ProofreadPage/ProofreadPage.body.php(109): EditPage->edit()
  #4 /srv/mediawiki/php-1.29.0-wmf.8/includes/Hooks.php(186): ProofreadPage::onCustomEditor(Article, User)
  #5 /srv/mediawiki/php-1.29.0-wmf.8/includes/actions/EditAction.php(57): Hooks::run(string, array)
  #6 /srv/mediawiki/php-1.29.0-wmf.8/includes/MediaWiki.php(495): EditAction->show()
  #7 /srv/mediawiki/php-1.29.0-wmf.8/includes/MediaWiki.php(289): MediaWiki->performAction(Article, Title)
  #8 /srv/mediawiki/php-1.29.0-wmf.8/includes/MediaWiki.php(858): MediaWiki->performRequest()
  #9 /srv/mediawiki/php-1.29.0-wmf.8/includes/MediaWiki.php(519): MediaWiki->main()
  #10 /srv/mediawiki/php-1.29.0-wmf.8/index.php(43): MediaWiki->run()
  #11 /srv/mediawiki/w/index.php(3): include(string)
  #12 {main}
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJan 18 2017, 10:45 PM
gerritbot subscribed.Jan 18 2017, 10:50 PM

Change 332895 had a related patch set uploaded (by Legoktm):
Revert "Use the parser to get each template parameter in the Index: namespace"

https://gerrit.wikimedia.org/r/332895

gerritbot added a project: Patch-For-Review.Jan 18 2017, 10:50 PM
gerritbot added a comment.Jan 18 2017, 10:54 PM

Change 332897 had a related patch set uploaded (by Chad):
Revert "Use the parser to get each template parameter in the Index: namespace"

https://gerrit.wikimedia.org/r/332897

gerritbot added a comment.Jan 18 2017, 10:55 PM

Change 332895 merged by jenkins-bot:
Revert "Use the parser to get each template parameter in the Index: namespace"

https://gerrit.wikimedia.org/r/332895

gerritbot added a comment.Jan 18 2017, 10:58 PM

Change 332897 merged by jenkins-bot:
Revert "Use the parser to get each template parameter in the Index: namespace"

https://gerrit.wikimedia.org/r/332897

Stashbot subscribed.Jan 18 2017, 10:59 PM

Mentioned in SAL (#wikimedia-operations) [2017-01-18T22:59:56Z] <demon@tin> Synchronized php-1.29.0-wmf.8/extensions/ProofreadPage/includes/index/ProofreadIndexPage.php: Unbreak, T155682 (duration: 00m 39s)

Legoktm mentioned this in T119330: Templates with parameters in the Index: namespace are dismissed when opening in editing.Jan 18 2017, 10:59 PM
• demon closed this task as Resolved.Jan 18 2017, 11:00 PM
• demon claimed this task.
• demon subscribed.

Should be fixed.

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 18 2017, 11:00 PM
Ankry added a comment.EditedJan 18 2017, 11:02 PM
In T155682#2950954, @demon wrote:

Should be fixed.

I confirm

Billinghurst subscribed.Jan 19 2017, 9:13 AM

Question. Is there a test in the system to create an index page as part of the testing of a mediawiki release? It would be useful, and to have that within the system if it doesn't exist.

Legoktm added a comment.Jan 19 2017, 10:07 AM
In T155682#2951903, @Billinghurst wrote:

Question. Is there a test in the system to create an index page as part of the testing of a mediawiki release? It would be useful, and to have that within the system if it doesn't exist.

No, that's something the ProofreadPage maintainers would need to add tests for it.

Tpt added a comment.Jan 19 2017, 10:35 AM
In T155682#2952041, @Legoktm wrote:
In T155682#2951903, @Billinghurst wrote:

Question. Is there a test in the system to create an index page as part of the testing of a mediawiki release? It would be useful, and to have that within the system if it doesn't exist.

No, that's something the ProofreadPage maintainers would need to add tests for it.

Yes, definitely. I've just opened a task about it: T155714

Billinghurst moved this task from Backlog to Done: to deploy/check on the ProofreadPage board.Mar 5 2017, 2:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits