Page MenuHomePhabricator
Create Task
Maniphest T156565

LQT uses deprecated methods causing jenkins to fail in master of massmessage
Closed, ResolvedPublic
Actions

Description

See: https://integration.wikimedia.org/ci/job/mwext-testextension-php55/34114/console

Details

SubjectRepoBranchLines +/-
Do not use deprecated methodsmediawiki/extensions/LiquidThreadsmaster+3 -3
Mark LQT tests skippedmediawiki/extensions/MassMessagemaster+2 -3
Customize query in gerrit

Event Timeline

Ladsgroup created this task.Jan 28 2017, 9:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2017, 9:52 PM
Ladsgroup triaged this task as High priority.Jan 28 2017, 9:56 PM

Not sure if it should be UBN! or not.

gerritbot subscribed.Jan 28 2017, 10:03 PM

Change 334851 had a related patch set uploaded (by Ladsgroup):
Mark LQT tests skipped

https://gerrit.wikimedia.org/r/334851

gerritbot added a project: Patch-For-Review.Jan 28 2017, 10:03 PM
gerritbot added a comment.Jan 28 2017, 10:06 PM

Change 334851 abandoned by Ladsgroup:
Mark LQT tests skipped

Reason:
Let's fix it

https://gerrit.wikimedia.org/r/334851

gerritbot added a comment.Jan 28 2017, 10:37 PM

Change 334853 had a related patch set uploaded (by Ladsgroup):
Do not use deprecated methods

https://gerrit.wikimedia.org/r/334853

Paladox subscribed.Jan 28 2017, 11:11 PM
Nirmos subscribed.Jan 29 2017, 1:43 AM

Should it really be getPaget in Thread.php when it's getPage in the others?

Ladsgroup added a comment.Jan 29 2017, 1:47 AM

@Nimros: Nope, you're right. I thought CI tests would catch this. Anyway. It's fixed now.

gerritbot added a comment.Jan 29 2017, 11:26 AM

Change 334853 merged by jenkins-bot:
Do not use deprecated methods

https://gerrit.wikimedia.org/r/334853

Ladsgroup added a comment.Jan 29 2017, 11:39 AM

https://gerrit.wikimedia.org/r/#/c/326317/ is passing now.

Ladsgroup closed this task as Resolved.Jan 29 2017, 11:39 AM
Ladsgroup claimed this task.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 29 2017, 11:39 AM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 29 2017, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL