Page MenuHomePhabricator
Create Task
Maniphest T156599

Visual diffing: Implement a fallback for when tree diffing takes too long
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In edge cases tree diffing can be very expensive (taking several seconds). We should probably bail out of these computations and fall back to something simpler.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (121100d74)mediawiki/extensions/VisualEditormaster+1 -1
VisualDiff: Implement linear diff timeout for edge casesVisualEditor/VisualEditormaster+22 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Jan 29 2017, 9:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2017, 9:04 PM
Esanders moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Jan 29 2017, 9:04 PM
gerritbot subscribed.Feb 2 2017, 2:51 PM

Change 335656 had a related patch set uploaded (by Esanders):
VisualDiff: Implement linear diff timeout for edge cases

https://gerrit.wikimedia.org/r/335656

gerritbot added a project: Patch-For-Review.Feb 2 2017, 2:51 PM
gerritbot added a comment.Feb 3 2017, 5:41 PM

Change 335656 merged by jenkins-bot:
VisualDiff: Implement linear diff timeout for edge cases

https://gerrit.wikimedia.org/r/335656

gerritbot added a comment.Feb 7 2017, 6:28 PM

Change 336450 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (121100d74)

https://gerrit.wikimedia.org/r/336450

Jdforrester-WMF closed this task as Resolved.Feb 7 2017, 7:02 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Feb 7 2017, 7:18 PM

Change 336450 merged by jenkins-bot:
Update VE core submodule to master (121100d74)

https://gerrit.wikimedia.org/r/336450

Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)); removed Patch-For-Review.Feb 7 2017, 7:39 PM
Jdforrester-WMF added a parent task: T143350: Let users choose a visual or wikitext diff in the review-your-changes tab.Mar 25 2017, 1:48 AM
Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 10:56 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 10 2017, 10:56 PM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Apr 12 2017, 11:55 PM
Ryasmeen moved this task from Verified to Non verifiable/Task on the User-Ryasmeen board.Apr 13 2017, 9:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits