Page MenuHomePhabricator

[Regression] Language inspector is too small, has scroll bars
Closed, ResolvedPublic1 Story Points

Description

Open VE on any page and open the language inspector, and you'll see vertical and horizontal scroll bars. I see these in both Firefox and Chrome, although on Chrome the vertical scroll bars go away if you close and reopen the inspector.

Event Timeline

Catrope created this task.Jan 31 2017, 4:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2017, 4:33 AM
Esanders renamed this task from Language inspector is too small, has scroll bars to [regression] Language inspector is too small, has scroll bars.Feb 1 2017, 9:29 PM

Bisect blames OOUI 0.18.4

Esanders added a comment.EditedFeb 1 2017, 9:46 PM

I suspect this is a box-sizing bug Nope, it's a change in selector specificity.

Change 335549 had a related patch set uploaded (by Esanders):
Fix width of labels in language inspector

https://gerrit.wikimedia.org/r/335549

Change 335549 merged by jenkins-bot:
Fix width of labels in language inspector

https://gerrit.wikimedia.org/r/335549

Jdforrester-WMF renamed this task from [regression] Language inspector is too small, has scroll bars to [Regression] Language inspector is too small, has scroll bars.Feb 1 2017, 11:41 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.

Change 335571 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (96ed6a4)

https://gerrit.wikimedia.org/r/335571

Change 335571 merged by jenkins-bot:
Update VE core submodule to master (96ed6a4)

https://gerrit.wikimedia.org/r/335571