Page MenuHomePhabricator
Create Task
Maniphest T156735

[Regression] Language inspector is too small, has scroll bars
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Open VE on any page and open the language inspector, and you'll see vertical and horizontal scroll bars. I see these in both Firefox and Chrome, although on Chrome the vertical scroll bars go away if you close and reopen the inspector.

language-inspector.png (220×431 px, 12 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (96ed6a4)mediawiki/extensions/VisualEditormaster+1 -1
Fix width of labels in language inspectorVisualEditor/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Jan 31 2017, 4:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2017, 4:33 AM
• Esanders renamed this task from Language inspector is too small, has scroll bars to [regression] Language inspector is too small, has scroll bars.Feb 1 2017, 9:29 PM
• Esanders subscribed.Feb 1 2017, 9:32 PM

Bisect blames OOUI 0.18.4

• Esanders added a subscriber: matmarex.Feb 1 2017, 9:33 PM
• Esanders added a comment.EditedFeb 1 2017, 9:46 PM

I suspect this is a box-sizing bug Nope, it's a change in selector specificity.

gerritbot subscribed.Feb 1 2017, 9:55 PM

Change 335549 had a related patch set uploaded (by Esanders):
Fix width of labels in language inspector

https://gerrit.wikimedia.org/r/335549

gerritbot added a project: Patch-For-Review.Feb 1 2017, 9:55 PM
gerritbot added a comment.Feb 1 2017, 10:32 PM

Change 335549 merged by jenkins-bot:
Fix width of labels in language inspector

https://gerrit.wikimedia.org/r/335549

Jdforrester-WMF renamed this task from [regression] Language inspector is too small, has scroll bars to [Regression] Language inspector is too small, has scroll bars.Feb 1 2017, 11:41 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF assigned this task to • Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Feb 1 2017, 11:42 PM

Change 335571 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (96ed6a4)

https://gerrit.wikimedia.org/r/335571

gerritbot added a project: Patch-For-Review.Feb 1 2017, 11:42 PM
gerritbot added a comment.Feb 2 2017, 10:33 AM

Change 335571 merged by jenkins-bot:
Update VE core submodule to master (96ed6a4)

https://gerrit.wikimedia.org/r/335571

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)).Feb 2 2017, 11:00 AM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 2 2017, 11:57 AM
Ryasmeen added a project: Verified.Feb 7 2017, 10:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits