[Popups] Value "undefined edits" for property "editCountBucket" is not one of ["0 edits","1-4 edits","5-99 edits","100-999 edits","1000+ edits"]
Seen on http://reading-web-staging.wmflabs.org/w/index.php?title=Main_Page&debug=true as a logged out user
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | phuedx | T149801 [EPIC] Refactor Hovercards (née Popups) | |||
| Resolved | ovasileva | T156290 Merge mpga branch into master | |||
| Resolved | • Jhernandez | T156893 mpga: Value "undefined edits" for property "editCountBucket" |
This is because the editCountBucket property is set regardless of whether the user is logged in. This should be trivial to fix (and equally trivial to write a test case for).
2 as there's a little cleanup that can be done to make this change even simpler: the BOOT-related part of the mw.popups.reducers.eventLogging reducer should be extracted into a helper function.
What's the the BOOT-related part of the mw.popups.reducers.eventLogging reducer ? Not clear to me what you mean here.
Oh you mean BOOT event not boot.js :) Still not 100% clear what you had in mind here. Would the helper function return base data?
The BOOT action, yes.
The function would return everything that's assigned to state.baseData.
Change 336210 had a related patch set uploaded (by Phuedx):
Hygiene: Extract helper from eventLogging reducer
Change 336211 had a related patch set uploaded (by Phuedx):
Don't log editCountBucket when user is logged out
Change 336210 merged by jenkins-bot:
Hygiene: Extract helper from eventLogging reducer
Change 336211 merged by jenkins-bot:
Don't log editCountBucket when user is logged out
I admit that 2 may have been a little on the high side /cc @MBinder_WMF.
I think it's fine. It's not a huge discrepancy from 1 or 3 (at least not for this team) and will probably be balanced out by other work in the grand scheme. Thanks for flagging. :)