Page MenuHomePhabricator

User::isPingLimitable() should handle CIDR notation in $wgRateLimitsExcludedIPs
Closed, ResolvedPublic

Description

User::isPingLimitable() should handle CIDR notation in $wgRateLimitsExcludedIPs. There are several IP ranges set in the Wikimedia config which apparently don't work.

Not sure what the performance implication would be, the current logic just does an in_array check.

Event Timeline

Tgr created this task.Feb 2 2017, 12:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2017, 12:58 AM

Change 335580 had a related patch set uploaded (by Gergő Tisza):
User::isPingLimitable(): handle CIDR notation in $wgRateLimitsExcludedIPs

https://gerrit.wikimedia.org/r/335580

Change 335580 merged by jenkins-bot:
User::isPingLimitable(): handle CIDR notation in $wgRateLimitsExcludedIPs

https://gerrit.wikimedia.org/r/335580

Change 339084 had a related patch set uploaded (by Gergő Tisza):
Mention $wgRateLimitsExcludedIPs semantics change in release notes

https://gerrit.wikimedia.org/r/339084

Change 339084 merged by jenkins-bot:
Mention $wgRateLimitsExcludedIPs semantics change in release notes

https://gerrit.wikimedia.org/r/339084

Krinkle closed this task as Resolved.May 8 2017, 12:21 AM
Krinkle claimed this task.
Krinkle moved this task from Backlog to Other on the MediaWiki-User-management board.