Don't throttle WMF office IP(s) for account creation in beta
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	greg
	Jan 29 2015, 5:10 AM

Description

Was ran into by Maryana and others.

Details

	Subject	Repo	Branch	Lines +/-
	Do not throw away $wgRateLimitsExcludedIPs defaults when there is a wiki-specific setting	operations/mediawiki-config	master	+1 -1
	beta: don't rate limit office IPs	operations/mediawiki-config	master	+4 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T87704 Account creation throttling too restrictive on Beta Cluster
Resolved	None	T87841 Don't throttle WMF office IP(s) for account creation in beta
Resolved	Krinkle	T156983 User::isPingLimitable() should handle CIDR notation in $wgRateLimitsExcludedIPs

Event Timeline

greg created this task.Jan 29 2015, 5:10 AM

greg raised the priority of this task from to Medium.

greg updated the task description. (Show Details)

greg added a project: Beta-Cluster-Infrastructure.

greg added subscribers: greg, Maryana, Aklapper.

greg moved this task from To Triage to Backlog on the Beta-Cluster-Infrastructure board.Jan 29 2015, 5:35 AM

Hi @cajoel, do you have the IP ranges for office handy? @JohnLewis would like to use them to implement this throttle. Thanks!

got it. hmm. @JKrauska < guillom> mutante: https://office.wikimedia.org/wiki/Office_IT/Network/IP_Addresses is this current and can i release it to John (NDAed volunteer)?

Dzahn assigned this task to • JKrauska.Feb 18 2015, 7:57 PM

https://wikitech.wikimedia.org/wiki/Tan.corp.wikimedia.org

In T87841#1047616, @Dzahn wrote:

https://wikitech.wikimedia.org/wiki/Tan.corp.wikimedia.org

Yeah that I believe is what @greg wants to be throttled.

These all have to go in the public throttle.php file to avoid throttling anyway, so an NDA won't help here.

@JohnLewis:

quote "As of summer 2014, the office network has been migrated to a new /24 block.

198.73.209.0/24

^ there, that /24 it is

Dzahn removed • JKrauska as the assignee of this task.Feb 18 2015, 10:28 PM

Change 191489 had a related patch set uploaded (by John F. Lewis):
beta: don't rate limit office IPs

https://gerrit.wikimedia.org/r/191489

Patch-For-Review

• JohnLewis claimed this task.Feb 18 2015, 11:07 PM

Change 191489 merged by jenkins-bot:
beta: don't rate limit office IPs

https://gerrit.wikimedia.org/r/191489

Should be good now. Thanks @JohnLewis !

hashar moved this task from Backlog to Done on the Beta-Cluster-Infrastructure board.Feb 23 2015, 8:23 PM

hashar mentioned this in T87704: Account creation throttling too restrictive on Beta Cluster.Mar 2 2015, 8:18 PM

• JohnLewis mentioned this in rOMWCb3fbb82d18c8: beta: don't rate limit office IPs.Mar 3 2015, 9:01 PM

Tgr renamed this task from Don't throttle WMF office IP(s) for account creation to Don't throttle WMF office IP(s) for account creation in beta.Feb 1 2017, 10:28 PM

Dzahn unsubscribed.Feb 1 2017, 10:31 PM

This does not seem to work. I don't think it ever did; $wgRateLimitsExcludedIPs is unrelated to account creation throttling. (The post-AuthManager task for that is T134953: Merge Throttler and ping limiter but I think the situation was the same before AuthManager as well.)

Hm, no, the code does check the ping limiter even if it doesn't actually use it, and so did the old code. Nevertheless, people still run into the limit.

Change 335561 had a related patch set uploaded (by Gergő Tisza):
Do not throw away $wgRateLimitsExcludedIPs defaults when there is a wiki-specific setting

https://gerrit.wikimedia.org/r/335561

gerritbot added a project: Patch-For-Review.Feb 1 2017, 11:18 PM

For the record, the way to temporarily lift the throttle is

P4853 Reset user account creation throttle for some IP

1	# mwscript eval.php --wiki=somewiki
2	$ip = '1.2.3.4';
3	$throttler = new \MediaWiki\Auth\Throttler( [ [ 'count' => 6, 'seconds' => 86400 ] ], [ 'type' => 'acctcreate', 'cache' => \ObjectCache::getLocalClusterInstance() ] );
4	$throttler->clear( null, $ip );