Page MenuHomePhabricator
Create Task
Maniphest T158294

Cell change missing in table diff
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

In tables.html, remove the row "I J K L", now edit the last column (DHP) to read XYZ.

The table should now look like:

pasted_file (137×136 px, 4 KB)

But the diff doesn't show the P->Z change:

pasted_file (151×155 px, 6 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (813c586a6)mediawiki/extensions/VisualEditormaster+1 -1
Correct some indices in visual diffVisualEditor/VisualEditormaster+27 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Feb 16 2017, 10:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2017, 10:52 AM
Esanders moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Feb 16 2017, 10:52 AM
Esanders added a comment.EditedFeb 17 2017, 7:26 PM

Another similar one:

Remove the last column, then insert a new row in the middle (zxy):

pasted_file (235×161 px, 9 KB)

Update: This is now T158518

Esanders mentioned this in T158445: VisualDiff: Handle table diffs separately.Feb 17 2017, 7:48 PM
Esanders added a subtask: T158445: VisualDiff: Handle table diffs separately.
gerritbot subscribed.Feb 19 2017, 9:55 PM

Change 338698 had a related patch set uploaded (by Tchanders):
Correct some indices in visual diff

https://gerrit.wikimedia.org/r/338698

gerritbot added a project: Patch-For-Review.Feb 19 2017, 9:55 PM
Tchanders added a comment.Feb 19 2017, 9:58 PM

The first example is fixed by correcting a few indices, but the second poses a more philosophical question about minimal-tree-diffing 2D matrices, so requires a bit more thinking...

Esanders mentioned this in T158518: Removing and inserting table cells breaks diff.Feb 19 2017, 10:14 PM

Have filed the second case as T158518

gerritbot added a comment.Feb 21 2017, 10:51 AM

Change 338698 merged by jenkins-bot:
Correct some indices in visual diff

https://gerrit.wikimedia.org/r/338698

gerritbot added a comment.Feb 23 2017, 7:38 PM

Change 339481 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

gerritbot added a comment.Feb 23 2017, 8:02 PM

Change 339481 merged by jenkins-bot:
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

Jdforrester-WMF closed this task as Resolved.Feb 23 2017, 8:08 PM
Jdforrester-WMF assigned this task to Tchanders.
Jdforrester-WMF edited projects, added VisualEditor-Tables; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 8.Feb 27 2017, 10:54 PM
Jdforrester-WMF added a project: MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)).Mar 3 2017, 12:59 AM
Jdforrester-WMF added a parent task: T143350: Let users choose a visual or wikitext diff in the review-your-changes tab.Mar 25 2017, 1:48 AM
Jdforrester-WMF added a project: VisualEditor-VisualDiffs.Apr 10 2017, 10:55 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 10 2017, 10:55 PM
Jdforrester-WMF removed a subtask: T158445: VisualDiff: Handle table diffs separately.Mar 6 2018, 2:27 PM
Jdforrester-WMF added a parent task: T158445: VisualDiff: Handle table diffs separately.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits