Page MenuHomePhabricator

Cell change missing in table diff
Closed, ResolvedPublic8 Estimated Story Points

Description

In tables.html, remove the row "I J K L", now edit the last column (DHP) to read XYZ.

The table should now look like:

But the diff doesn't show the P->Z change:

Event Timeline

Another similar one:

Remove the last column, then insert a new row in the middle (zxy):

Update: This is now T158518

Change 338698 had a related patch set uploaded (by Tchanders):
Correct some indices in visual diff

https://gerrit.wikimedia.org/r/338698

The first example is fixed by correcting a few indices, but the second poses a more philosophical question about minimal-tree-diffing 2D matrices, so requires a bit more thinking...

Change 338698 merged by jenkins-bot:
Correct some indices in visual diff

https://gerrit.wikimedia.org/r/338698

Change 339481 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

Change 339481 merged by jenkins-bot:
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481