Maniphest T158858

Horizontal gradient appearing on right side of text for RTL page previews
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Testing notes

Scenario 1: Text truncation on an RTL page for an RTL page

Visit http://reading-web-staging.wmflabs.org/wiki/T158858.
Hover over the "Rtl popups" link and wait for a preview to appear.
Observe that a horizontal gradient appears on the LHS of the preview text.

Scenario 2: Text truncation on an LTR page for an RTL page

Visit http://reading-web-staging.wmflabs.org/wiki/Category:Popups_corpus.
Hover over the "Rtl popups" link and wait for a preview to appear.
Observe that a horizontal gradient appears on the LHS of the preview text.
Visit http://reading-web-staging.wmflabs.org/wiki/Category:Popups_corpus.
Hover over the "Paper" link and wait for a preview to appear.
Observe that a horizontal appears on the RHS of the preview text.

Original bug report

Steps to recreate:

Go to: the page for Ada Lovelace as a logged in user on Hebrew Wikipedia
Hover over מתמטיקאית

Expected behavior - horizontal gradient appears on the left side of text
Observed behavior - horizontal gradient appears on the right side of text

Screen Shot 2017-02-23 at 3.48.04 PM.png (324×501 px, 168 KB)

Details

Subject	Repo	Branch	Lines +/-
truncation: Fix fade direction for RTL previews	mediawiki/extensions/Popups	master	+9 -5
i18n: Fix popups fade on RTL	mediawiki/extensions/Popups	master	+2 -0
Don't flip extract truncation mechanism	mediawiki/extensions/Popups	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T160614: Horizontal gradient appearing on wrong side of text for RTL page previews
T159485: gradient at the end of the page preview goes the wrong way in RTL wikis
T159101: Hovercards: the fading ::after CSS displays wrong on RTL wikis
T156290: Merge mpga branch into master
Mentioned Here: rEPOP84a60c4db7f7: truncation: Fix fade direction for RTL previews

Event Timeline

ovasileva created this task.Feb 23 2017, 2:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2017, 2:49 PM

ovasileva triaged this task as High priority.Feb 23 2017, 2:49 PM

ovasileva mentioned this in T156290: Merge mpga branch into master.Feb 23 2017, 2:57 PM

phuedx claimed this task.Feb 23 2017, 5:24 PM

phuedx edited projects, added Reading-Web-Sprint-92-🍜, Unplanned-Sprint-Work; removed Reading-Web-Sprint-93-🔍🔍🔍🔍🔍.

phuedx moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-92-🍜 board.

Change 339454 had a related patch set uploaded (by Phuedx):
Don't flip extract truncation mechanism

https://gerrit.wikimedia.org/r/339454

gerritbot added a project: Patch-For-Review.Feb 23 2017, 5:57 PM

phuedx set the point value for this task to 1.Feb 23 2017, 6:15 PM

We'll need a page on the staging server that has a page content language that's RTL with a link to a page that has a page content language that's RTL, e.g. RTL popups links to RTL popups part deux.

phuedx moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-92-🍜 board.Feb 23 2017, 6:20 PM

ovasileva moved this task from Incoming to 2016-17 Q3 on the Web-Team-Backlog board.Feb 24 2017, 1:20 PM

Change 339940 had a related patch set uploaded (by Phuedx):
i18n: Fix popups fade on RTL

https://gerrit.wikimedia.org/r/339940

Change 339454 abandoned by Phuedx:
Don't flip extract truncation mechanism

Reason:
Duplicated by I0d50a8b5.

https://gerrit.wikimedia.org/r/339454

Change 339940 merged by jenkins-bot:
i18n: Fix popups fade on RTL

https://gerrit.wikimedia.org/r/339940

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)).Feb 27 2017, 10:00 AM

phuedx moved this task from Needs Code Review to Needs QA on the Reading-Web-Sprint-92-🍜 board.Feb 27 2017, 10:21 AM

phuedx updated the task description. (Show Details)Feb 27 2017, 10:28 AM

phuedx updated the task description. (Show Details)Feb 27 2017, 10:41 AM

Change 340106 had a related patch set uploaded (by Phuedx):
truncation: Fix fade direction for RTL previews

https://gerrit.wikimedia.org/r/340106

rEPOP84a60c4db7f7: truncation: Fix fade direction for RTL previews fixes the direction of the gradient used to truncate the preview text. The UBN!-like part of this task, the position of the truncating element, has already been fixed and can be tested on the staging server.

• Jhernandez merged a task: T159101: Hovercards: the fading ::after CSS displays wrong on RTL wikis.Feb 27 2017, 1:38 PM

• Jhernandez mentioned this in T159101: Hovercards: the fading ::after CSS displays wrong on RTL wikis.

• Jhernandez added a subscriber: Kipod.