Page MenuHomePhabricator
Create Task
Maniphest T158941

Wikibase: Fix tests to not assume synchronous jQuery.Deferred
Closed, ResolvedPublic
Actions

Description

Draft change with details at https://gerrit.wikimedia.org/r/323445/.

Each QUnit test should either return a Promise to QUnit.test (which QUnit will automatically wait for and also report a test failure if the Promise is rejected), or manually use assert.async() where needed.

Examples:

QUnit.test( 'example should pass', function ( assert ) {
  return something().then( function ( val ) {
    assert.equals( val, 'expected' );
  } );
} );

QUnit.test( 'example should fail', function ( assert ) {
  var done = assert.async();
  something().fail( function ( val ) {
    assert.equals( val, 'error message' );
  } ).always( done );
} );

This is in preparation for jQuery 3.0, where $.Deferred callbacks are processed asynchronously. https://jquery.com/upgrade-guide/3.0/

Failures can be seen at the pending core patch: https://gerrit.wikimedia.org/r/322812/.

Details

SubjectRepoBranchLines +/-
Prepare `SiteLinkSetsChanger.tests` for jQuery version migrationmediawiki/extensions/Wikibasemaster+25 -19
Prepare `EntityTermsChanger.tests` for jQuery version migrationmediawiki/extensions/Wikibasemaster+286 -176
Replace QUnit.start()/.stop() with assert.async()mediawiki/extensions/Wikibasemaster+30 -23
Replace QUnit.start()/.stop() with assert.async()mediawiki/extensions/Wikibasemaster+6 -8
Don't assume synchronous jQuery.Deferred in QUnit testsmediawiki/extensions/Wikibasemaster+5 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Feb 24 2017, 5:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2017, 5:36 AM
gerritbot subscribed.Feb 24 2017, 5:39 AM

Change 323445 had a related patch set uploaded (by Krinkle):
Don't assume synchronous jQuery.Deferred in QUnit tests

https://gerrit.wikimedia.org/r/323445

gerritbot added a project: Patch-For-Review.Feb 24 2017, 5:39 AM
Krinkle removed a project: Patch-For-Review.Feb 28 2017, 11:38 PM
Jdforrester-WMF added a subscriber: Lydia_Pintscher.Feb 28 2017, 11:47 PM
gerritbot added a comment.Mar 8 2017, 11:37 AM

Change 323445 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Don't assume synchronous jQuery.Deferred in QUnit tests

https://gerrit.wikimedia.org/r/323445

Krinkle added a subscriber: • Jonas.Mar 9 2017, 10:37 PM
In T158941#3083796, @gerritbot wrote:

Change 323445 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Don't assume synchronous jQuery.Deferred in QUnit tests

https://gerrit.wikimedia.org/r/323445

@Lydia_Pintscher @Jonas Per my comment on Gerrit, this patch was not finished. Please ensure the other tests are migrated as well. You can test locally by checking out https://gerrit.wikimedia.org/r/#/c/322812/ in your MediaWiki install and run the Wikibase test suite to observe the failures. Essentially just needs the same patterns in that patch applied to the remaining tests. This is blocking the migration to jQuery 3.0.

• Jonas added a subscriber: thiemowmde.Mar 14 2017, 9:04 PM
Lydia_Pintscher added a project: Wikidata-Former-Sprint-Board.Mar 23 2017, 11:56 AM
• Jonas raised the priority of this task from Medium to High.Mar 23 2017, 12:10 PM
• Jonas moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Mar 23 2017, 3:05 PM
gerritbot added a comment.Mar 23 2017, 3:37 PM

Change 344405 had a related patch set uploaded (by Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/344405

gerritbot added a project: Patch-For-Review.Mar 23 2017, 3:37 PM
• Jonas claimed this task.Mar 24 2017, 10:53 AM
• Jonas moved this task from Backlog to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Apr 3 2017, 8:29 AM

Change 344405 merged by Hoo man:
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/344405

Jdforrester-WMF subscribed.Apr 5 2017, 6:51 PM

What's outstanding here?

Krinkle added a comment.EditedApr 5 2017, 10:53 PM
In T158941#3158377, @Jdforrester-WMF wrote:

What's outstanding here?

From comments on https://gerrit.wikimedia.org/r/344405:

@Jonas wrote:

@Krinkle this is what you need for all Wikibase tests right?

@Krinkle wrote:

LGTM, but there are a few more failures remaining still at https://gerrit.wikimedia.org/r/#/c/322812/

@Jonas wrote:

I just wanted to check if that is the fix you need, before I fix all the places needed [..]

So, like the first patch, this only converted a few tests. There are still a handful left that use the unsupported format.

FAILED TESTS:
  wikibase.entityChangers.EntityTermsChanger
    ✖ save performs correct API calls for new label
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for changed label
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for removed label
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for new description
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for changed description
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for removed description
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for new aliases
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for changed aliases
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API calls for removed aliases
    failed, expected argument to be truthy, was: false

  wikibase.entityChangers.SiteLinkSetsChanger
    ✖ save performs correct API call
    failed, expected argument to be truthy, was: false

    ✖ save performs correct API call for removal
    failed, expected argument to be truthy, was: false

  jquery.wikibase.entitytermsforlanguagelistview
    ✖ Create & destroy
    afterEach failed on Create & destroy: Unfinished animations: 2
    Error: Unfinished animations: 2

    ✖ setError()
    afterEach failed on setError(): Unfinished animations: 2
    Error: Unfinished animations: 2
Krinkle removed a project: Patch-For-Review.Apr 5 2017, 10:53 PM
gerritbot added a comment.Apr 6 2017, 12:55 PM

Change 346753 had a related patch set uploaded (by Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/346753

gerritbot added a project: Patch-For-Review.Apr 6 2017, 12:55 PM
gerritbot added a comment.Apr 8 2017, 4:02 AM

Change 346753 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace QUnit.start()/.stop() with assert.async()

https://gerrit.wikimedia.org/r/346753

gerritbot added a comment.Apr 8 2017, 1:35 PM

Change 347167 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/Wikibase@master] Prepare EntityTermsChanger.tests for jQuery version migration

https://gerrit.wikimedia.org/r/347167

gerritbot added a comment.Apr 10 2017, 11:00 AM

Change 347349 had a related patch set uploaded (by Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Prepare SiteLinkSetsChanger.tests for jQuery version migration

https://gerrit.wikimedia.org/r/347349

gerritbot added a comment.Apr 10 2017, 11:14 AM

Change 347167 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Prepare EntityTermsChanger.tests for jQuery version migration

https://gerrit.wikimedia.org/r/347167

• Jonas moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Apr 11 2017, 1:52 PM
gerritbot added a comment.Apr 11 2017, 7:23 PM

Change 347349 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Prepare SiteLinkSetsChanger.tests for jQuery version migration

https://gerrit.wikimedia.org/r/347349

Jdforrester-WMF updated the task description. (Show Details)Apr 12 2017, 1:12 AM
Krinkle closed this task as Resolved.Apr 12 2017, 6:07 PM

@Jonas Thanks!

Lydia_Pintscher moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Apr 17 2017, 5:27 PM
Jdforrester-WMF mentioned this in T163123: Intermittent failures of mwext-qunit-jessie.Apr 17 2017, 5:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits