the code
|| displayed text after click submit button
should display a text only after clicking the "submit" button. Except that there, it appears by default
https://en.wikiversity.org/wiki/Help:Quiz#Inserting_feedback
Crochet.david | |
Mar 6 2017, 6:25 PM |
F8420089: phone.png | |
Jun 9 2017, 6:34 AM |
F6369174: tmpOeuTNz-save.png | |
Mar 9 2017, 2:08 PM |
F6369192: tmpVVBAA1-save.png | |
Mar 9 2017, 2:08 PM |
the code
|| displayed text after click submit button
should display a text only after clicking the "submit" button. Except that there, it appears by default
https://en.wikiversity.org/wiki/Help:Quiz#Inserting_feedback
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | cristianbaldi | T159732 The quiz extension displays a "feedback" text, which should not appear by default, on mobile | |||
Resolved | None | T160070 Mobile version of wikiversity is not loading (some?) CSS |
Hey David,
thanks for the report. We already fixed this in the repository. We are shipping the fix in the next release (which should happen tomorrow).
Unfortunately the bug happened because I tweaked things a bit and forgot to test that feature.
I also confirm that bug, I even tried to purge the page on mobile server-side.
It is very very odd. Are we sure that this worked before?
Also it should not be a problem anymore (I hope) with next release, feedback is disabled server side.
Anybody has any idea?
It is also unrelated with the other commit we shipped a few days ago, really no idea.
It is possible it never worked. Feedback was being hidden by a CSS class so if mobile CSS overwrote that it might have been a pre-existing bug....
Ironically I held back this latest fix until the next deploy train, which might have fixed it (since the feedback is now being generated server side instead of being hidden by CSS.)
I isolated the problem. The CSS does not get loaded on mobile (and probably some other resources).
Desktop: (CSS is there, look at the bottom)
So yeah, the problem was there before and nobody noticed I guess.
Weird. Well anyway, as you say, https://gerrit.wikimedia.org/r/#/c/341588/ should fix this problem.
I tried some other things and the CSS otherwise seems to be working okay (like highlight the wrong answer in red)... I created a subtask but maybe we don't need it?
It is definitely worth investigating. Especially because some other things like the Javascript might not get loaded on mobile (since they are loaded in the code in the same way).
Some of the other CSS seems to be working probably because that CSS is added inline to the HTML and not from the CSS file.
I think the task is needed, at least until we define the problem.