Write unit tests for Thanks JS modules
Open, Needs TriagePublic

Description

Of the five JavaScript modules in Thanks, only ext.thanks.mobilediff.js currently has a QUnit test module. Tests should be written for the remaining four modules:

Notes

  • 2 tests per GCI participant so this will be a task with 2 instant counts for the 4 tests to be written.
  • Patches should indicate which tests have been added (in commit message as well).
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 12 2017, 1:33 AM
Restricted Application added subscribers: Mattflaschen-WMF, Aklapper. · View Herald Transcript
happy5214 updated the task description. (Show Details)Mar 12 2017, 1:34 AM
happy5214 updated the task description. (Show Details)Mar 13 2017, 3:10 AM

jquery.findWithParent.js was copied from Flow, so that unit test should be added there.

Framawiki added a subscriber: Framawiki.

I will (try to) mentor this task for Google-Code-in-2018.

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 30 2018, 4:59 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 6 2018, 11:04 AM
JTannerWMF moved this task from Inbox to External on the Growth-Team board.Sep 6 2018, 11:04 AM
D3r1ck01 updated the task description. (Show Details)Sep 21 2018, 1:10 PM
D3r1ck01 added a subscriber: D3r1ck01.

Imported as: https://codein.withgoogle.com/tasks/5802758423707648/. Will give a helping hand to @Framawiki in mentoring this.

D3r1ck01 updated the task description. (Show Details)Sep 21 2018, 1:15 PM
D3r1ck01 updated the task description. (Show Details)Sep 21 2018, 1:22 PM

@D3r1ck01: On the GCI site, I've split this into two tasks so students do not collide with choosing which tests to work on, set the category to QA as this is about testing, and added links to the extension homepages and explained the expected outcome (patches in Gerrit):
https://codein.withgoogle.com/tasks/5802758423707648/ https://codein.withgoogle.com/tasks/5059170198880256/

Thanks so much @Aklapper. Indeed this will solve the collision problem you highlighted :)