Page MenuHomePhabricator
Create Task
Maniphest T160267

Write unit tests for Thanks JS modules
Open, Needs TriagePublic
Actions

Description

Of the five four JavaScript modules in Thanks, only ext.thanks.thank.js currently has a QUnit test module. Tests should be written for the remaining modules:

Notes

  • 2 tests per GCI participant so this will be a task with 2 instant counts for the 4 tests to be written.
  • Patches should indicate which tests have been added (in commit message as well).

Details

SubjectRepoBranchLines +/-
Written QUnit testsmediawiki/extensions/Thanksmaster+243 -10
Thanks/thank: Add tests for thanked cookie and getUserGender()mediawiki/extensions/Thanksmaster+70 -0
jquery.findWithParent.js: Add QUnit testsmediawiki/extensions/Flowmaster+38 -0
Customize query in gerrit

Event Timeline

happy5214 created this task.Mar 12 2017, 1:33 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 12 2017, 1:33 AM
Restricted Application added subscribers: • Mattflaschen-WMF, Aklapper. · View Herald Transcript
happy5214 updated the task description. (Show Details)Mar 12 2017, 1:34 AM
happy5214 updated the task description. (Show Details)Mar 13 2017, 3:10 AM

jquery.findWithParent.js was copied from Flow, so that unit test should be added there.

• jmatazzoni moved this task from Untriaged to Medium-Term Interest on the Collaboration-Team-Triage board.Mar 22 2017, 12:04 AM
Framawiki added a project: Google-Code-in-2018.Aug 30 2018, 4:59 PM
Framawiki subscribed.

I will (try to) mentor this task for Google-Code-in-2018.

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 30 2018, 4:59 PM
JTannerWMF removed a project: Growth-Team.Sep 6 2018, 11:04 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 6 2018, 11:04 AM
JTannerWMF moved this task from Inbox to External on the Growth-Team board.Sep 6 2018, 11:04 AM
xSavitar updated the task description. (Show Details)Sep 21 2018, 1:10 PM
xSavitar moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.EditedSep 21 2018, 1:14 PM
xSavitar subscribed.

Imported as: https://codein.withgoogle.com/tasks/5802758423707648/. Will give a helping hand to @Framawiki in mentoring this.

xSavitar updated the task description. (Show Details)Sep 21 2018, 1:15 PM
xSavitar updated the task description. (Show Details)Sep 21 2018, 1:22 PM
Aklapper added a comment.Oct 3 2018, 12:38 PM

@D3r1ck01: On the GCI site, I've split this into two tasks so students do not collide with choosing which tests to work on, set the category to QA as this is about testing, and added links to the extension homepages and explained the expected outcome (patches in Gerrit):
https://codein.withgoogle.com/tasks/5802758423707648/ https://codein.withgoogle.com/tasks/5059170198880256/

xSavitar added a comment.Oct 3 2018, 1:15 PM

Thanks so much @Aklapper. Indeed this will solve the collision problem you highlighted :)

KacasPiesel claimed this task.Oct 23 2018, 6:14 PM
KacasPiesel removed KacasPiesel as the assignee of this task.Nov 7 2018, 12:52 PM
KacasPiesel subscribed.
gerritbot subscribed.Nov 13 2018, 9:13 PM

Change 473281 had a related patch set uploaded (by Takidelfin; owner: Takidelfin):
[mediawiki/extensions/Thanks@master] Thanks/thank: Add tests for thanked cookie and getUserGender()

https://gerrit.wikimedia.org/r/473281

gerritbot added a project: Patch-For-Review.Nov 13 2018, 9:13 PM
takidelfin subscribed.Nov 13 2018, 9:14 PM
gerritbot added a comment.Nov 14 2018, 4:23 PM

Change 473556 had a related patch set uploaded (by Flutterish; owner: Flutterish):
[mediawiki/extensions/Thanks@master] Written QUnit tests

https://gerrit.wikimedia.org/r/473556

gerritbot added a comment.Nov 14 2018, 7:40 PM

Change 473592 had a related patch set uploaded (by Takidelfin; owner: Takidelfin):
[mediawiki/extensions/Flow@master] jQuery/findWithParent: Add QUnit tests

https://gerrit.wikimedia.org/r/473592

gerritbot added a comment.Nov 15 2018, 12:14 AM

Change 473592 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] jquery.findWithParent.js: Add QUnit tests

https://gerrit.wikimedia.org/r/473592

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 15 2018, 1:00 AM
gerritbot added a comment.Nov 16 2018, 6:15 PM

Change 473281 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Thanks/thank: Add tests for thanked cookie and getUserGender()

https://gerrit.wikimedia.org/r/473281

matmarex subscribed.Nov 20 2018, 6:32 AM

Patch https://gerrit.wikimedia.org/r/473556 is blocked by a mysterious test failure that I can't reproduce locally. I have approved the relevant GCI task, but this Phabricator task is not fixed until someone figures that one out, or writes unit tests from scratch and doesn't run into this failure.

matmarex updated the task description. (Show Details)Nov 20 2018, 6:34 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:56 PM
Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:09 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 1 2023, 8:16 PM
Jdlrobson updated the task description. (Show Details)Mar 19 2024, 12:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits