Page MenuHomePhabricator
Create Task
Maniphest T161283

Notice: Undefined index: responses
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Notice: Undefined index: responses in /srv/mediawiki/php-1.29.0-wmf.17/extensions/CirrusSearch/includes/MultiSearchRequestLog.php on line 75

Details

SubjectRepoBranchLines +/-
Check if $responseData['responses'] is set before usemediawiki/extensions/CirrusSearchmaster+22 -1
Customize query in gerrit

Event Timeline

Reedy created this task.Mar 24 2017, 2:37 AM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptMar 24 2017, 2:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added a project: Wikimedia-production-error.Mar 24 2017, 2:38 AM
• Deskana triaged this task as Medium priority.Mar 30 2017, 5:13 PM
• Deskana moved this task from needs triage to Up Next on the Discovery-Search board.
• Deskana subscribed.

Needs further investigation.

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Apr 6 2017, 7:02 PM
debt moved this task from Up Next to search-icebox on the Discovery-Search board.Oct 19 2017, 5:26 PM
debt subscribed.

This error is still happening, but the amount of events is less than 100 in the last 30 days; not super urgent.

gerritbot subscribed.Dec 6 2017, 11:21 PM

Change 395883 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/CirrusSearch@master] Check if $responseData['responses'] is set before use

https://gerrit.wikimedia.org/r/395883

gerritbot added a project: Patch-For-Review.Dec 6 2017, 11:21 PM
Umherirrender claimed this task.Dec 6 2017, 11:23 PM
gerritbot added a comment.Jan 2 2018, 11:13 PM

Change 395883 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Check if $responseData['responses'] is set before use

https://gerrit.wikimedia.org/r/395883

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 3 2018, 12:00 AM
Umherirrender closed this task as Resolved.Jan 3 2018, 4:38 PM

The undefined index is now handled in the code.

The new message "Response does not has any data." + the message from Elastica will be shown in the logs instead.

Reedy removed a project: Patch-For-Review.May 17 2019, 9:47 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits