Figure out how LoginNotify interfaces with CheckUser. Do we want this functionality on the cluster? Should we put it behind a feature flag for the initial deployment?
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Rename functions so as to not confuse with with CheckUser extension | mediawiki/extensions/LoginNotify | master | +24 -24 |
Related Objects
Related Objects
Event Timeline
Comment Actions
As far as I can tell, all we're doing is querying the cu_changes table to see if the user's IP was recently used – so only reads, no writes. If the user's IP is not in the local wiki's cu_changes, and CentralAuth is installed, it will check the corresponding cu_changes table (if it exists) in the top 10 wikis edited by the user. This is already explained in the README.
This here patch is to rename some of the functions that sounded like they did CheckUser stuff when they didn't: https://gerrit.wikimedia.org/r/#/c/348757/
Comment Actions
@MusikAnimal: Nice work. Can you also update the documentation in the Usage section at https://www.mediawiki.org/wiki/Extension:LoginNotify?
Comment Actions
Change 348757 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Rename functions so as to not confuse with with CheckUser extension
Comment Actions
I made some copy edits. Integration with CheckUser is also briefly explained in the lead and Installation section