Maniphest T163193

Browser test fail due to OOUI change on EditPage button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-Fisch
	Apr 18 2017, 9:08 AM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

Switching the EditPage buttons to OOUI{1}[2] broke some browser tests[3] because the PageObject elements[3] do not fit the DOM anymore.

[1] https://phabricator.wikimedia.org/T111088
[2] https://gerrit.wikimedia.org/r/#/c/231600/
[3] https://integration.wikimedia.org/ci/job/mwext-mw-selenium-jessie/3018/console
[4] https://phabricator.wikimedia.org/source/mediawiki/browse/master/tests/browser/features/support/pages/edit_page.rb

Details

	Subject	Repo	Branch	Lines +/-
	Fix EditPage button/input accessors on PageObject	mediawiki/core	master	+3 -3
	Fix EditPage button accessors on PageObject	mediawiki/core	master	+3 -3

Customize query in gerrit

Event Timeline

WMDE-Fisch created this task.Apr 18 2017, 9:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2017, 9:08 AM

WMDE-Fisch claimed this task.Apr 18 2017, 9:08 AM

WMDE-Fisch moved this task from Proposed to Sprint ready on the WMDE-TechWish board.

Change 348694 had a related patch set uploaded (by WMDE-Fisch):
[mediawiki/core@master] Fix EditPage button accessors on PageObject

https://gerrit.wikimedia.org/r/348694

gerritbot added a project: Patch-For-Review.Apr 18 2017, 9:16 AM

WMDE-Fisch moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.Apr 18 2017, 9:19 AM

Change 348694 merged by jenkins-bot:
[mediawiki/core@master] Fix EditPage button accessors on PageObject

https://gerrit.wikimedia.org/r/348694

WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.Apr 18 2017, 12:15 PM

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), MW-1.29-release-notes.Apr 18 2017, 1:00 PM

Whoops, nice spot, thank you. Resolved?

Jdforrester-WMF removed a project: Patch-For-Review.Apr 19 2017, 1:53 AM

Yes, Resolved :-)

Change 349183 had a related patch set uploaded (by WMDE-Fisch):
[mediawiki/core@master] Fix EditPage button/input accessors on PageObject

https://gerrit.wikimedia.org/r/349183

gerritbot added a project: Patch-For-Review.Apr 20 2017, 9:32 AM

Tests broke again due to: https://gerrit.wikimedia.org/r/#/c/348765/ - the above patch addresses that.

WMDE-Fisch moved this task from Done to Currently in sprint on the WMDE-TechWish board.Apr 20 2017, 9:34 AM

Change 349183 merged by jenkins-bot:
[mediawiki/core@master] Fix EditPage button/input accessors on PageObject

https://gerrit.wikimedia.org/r/349183

matmarex closed this task as Resolved.Apr 20 2017, 3:26 PM

matmarex removed a project: Patch-For-Review.

matmarex subscribed.

WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.Apr 25 2017, 10:06 AM

WMDE-Fisch moved this task from Done to Demoed on the WMDE-TechWish board.Apr 25 2017, 3:24 PM

Tobi_WMDE_SW moved this task from Incoming to Edit Conflict Handling on the TCB-Team (now WMDE-TechWish) board.Jun 6 2017, 10:14 AM

Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 11:59 AM

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:26 PM