Page MenuHomePhabricator
Create Task
Maniphest T164037

Move all the code out of MwEmbedSupport and into TimedMediaHandler, its only user
Closed, ResolvedPublic
Actions

Description

Leave the MwEmbedSupport repo behind as empty so people calling it don't die horribly.

Details

SubjectRepoBranchLines +/-
Migrate in all the MwEmbedSupport extension's code so we can kill it offmediawiki/extensions/TimedMediaHandlerREL1_31+6 K -10
Note that the code of this extension was merged into TimedMediaHandlermediawiki/extensions/MwEmbedSupportmaster+3 -0
Hollow-out repositorymediawiki/extensions/MwEmbedSupportmaster+1 -6 K
Migrate in all the MwEmbedSupport extension's code so we can kill it offmediawiki/extensions/TimedMediaHandlermaster+6 K -10
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Apr 27 2017, 10:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2017, 10:04 PM
Jdforrester-WMF added a comment.Apr 27 2017, 10:05 PM

Doing this would fix T47918: MwEmbedSupport doesn't work with non standard layouts.

gerritbot subscribed.Apr 27 2017, 10:22 PM

Change 350755 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MwEmbedSupport@master] Hollow-out repository

https://gerrit.wikimedia.org/r/350755

gerritbot added a project: Patch-For-Review.Apr 27 2017, 10:22 PM
gerritbot added a comment.Apr 27 2017, 10:32 PM

Change 350758 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@master] WIP: Migrate in all the MwEmbedSupport extension

https://gerrit.wikimedia.org/r/350758

Jdforrester-WMF mentioned this in T47918: MwEmbedSupport doesn't work with non standard layouts.Apr 27 2017, 10:34 PM
Paladox subscribed.Apr 28 2017, 12:59 AM
TheDJ subscribed.Apr 28 2017, 9:32 AM
gerritbot added a comment.Jun 22 2018, 12:24 AM

Change 350758 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Migrate in all the MwEmbedSupport extension's code so we can kill it off

https://gerrit.wikimedia.org/r/350758

Jdforrester-WMF closed this task as Resolved.Jun 22 2018, 12:35 AM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed Patch-For-Review.

Gosh.

Jdforrester-WMF mentioned this in T197918: Archive the MwEmbedSupport extension.Jun 22 2018, 1:00 AM
gerritbot added a comment.Jun 22 2018, 7:31 PM

Change 350755 merged by jenkins-bot:
[mediawiki/extensions/MwEmbedSupport@master] Hollow-out repository

https://gerrit.wikimedia.org/r/350755

MarcoAurelio subscribed.Jun 22 2018, 7:34 PM

Maybe also add a MOVED or MERGED file with The code of this extension has been merged into Extension:TimedMediaHandler. Please see $info-link(s) for details?

gerritbot added a comment.Jun 23 2018, 7:45 AM

Change 441589 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/MwEmbedSupport@master] Note that the code of this extension was merged into TimedMediaHandler

https://gerrit.wikimedia.org/r/441589

gerritbot added a project: Patch-For-Review.Jun 23 2018, 7:45 AM
gerritbot added a comment.Jun 25 2018, 4:34 PM

Change 441589 merged by jenkins-bot:
[mediawiki/extensions/MwEmbedSupport@master] Note that the code of this extension was merged into TimedMediaHandler

https://gerrit.wikimedia.org/r/441589

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 30 2018, 3:01 PM
Liuxinyu970226 mentioned this in MediaWiki-extensions-MwEmbedSupport.Jul 18 2018, 5:13 AM
gerritbot added a comment.Aug 7 2018, 5:11 PM

Change 451036 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@REL1_31] Migrate in all the MwEmbedSupport extension's code so we can kill it off

https://gerrit.wikimedia.org/r/451036

gerritbot added a comment.Aug 7 2018, 9:42 PM

Change 451036 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@REL1_31] Migrate in all the MwEmbedSupport extension's code so we can kill it off

https://gerrit.wikimedia.org/r/451036

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits