Page MenuHomePhabricator

There should be a longer wait before displaying `There is an uneven amount of parenthesis`
Closed, ResolvedPublic

Description

Right now, the Translate extension will tell you when parentheses are unbalanced.

Screenshot 2017-05-02 14.31.13.png (492×680 px, 29 KB)

This is great! But it does so as you are typing, which means the text box is pushed up/down the page unexpectedly which makes it difficult to press the "Save translation" button or to click elsewhere in the box, since things move around.

It would be great if this message only appeared after a larger timespan has passed to prevent this.

Event Timeline

Delaying it until save button is clicked would be counterproductive, as the editor is hidden when the button is clicked. The translator would not see the notice.

Delaying it until save button is clicked would be counterproductive, as the editor is hidden when the button is clicked.

Agreed. If possible, it's nice to wait a couple seconds (or when the user has paused typing for a fraction of second), as I think core now does in Special:UserLogin before throwing warnings about usernames.

jrbs renamed this task from `There is an uneven amount of parenthesis` should only appear once saving a message to There should be a longer wait before displaying `There is an uneven amount of parenthesis`.May 3 2017, 7:40 AM
jrbs updated the task description. (Show Details)

Change 823140 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/Translate@master] Increase the time to display a warning to 2 seconds

https://gerrit.wikimedia.org/r/823140

Change 823140 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Increase the time to display a warning to 2 seconds

https://gerrit.wikimedia.org/r/823140

Quadrupling is a big change. Please test carefully that this does not make translators miss warnings more often.

abi_ added a subscriber: abi_.

I'm noticing that its quite easy to miss this warning now. I think we should tweak this some more.

Nikerabbit added a subscriber: Amire80.

Moving to priority backlog due to inactivity.

Nikerabbit changed the task status from Open to In Progress.Sep 13 2022, 11:12 AM

Change 843405 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Decrease time to display warning on uneven parenthesis

https://gerrit.wikimedia.org/r/843405

Change 843405 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Tux: Decrease time to display validation warnings to 1 second

https://gerrit.wikimedia.org/r/843405

Tested on translatewiki with positive results. The wait time is not too long nor too short for 'key-up' event to respond with a warning in the event parenthesis are not even.