Page MenuHomePhabricator

Consolidate page loading, library state
Closed, InvalidPublic

Description

How can we break this up?

MobileApp/styles/android/loading.less
apps-android-wikipedia/www/js/loader.js // bootstrap / bootloader
apps-android-wikipedia/www/js/sections.js
apps-android-wikipedia/www/js/preview.js
MobileApp/styles/preview.less
apps-android-wikipedia/www/tests/inject.js -- do we want this? it's pretty powerful. how do we use a non-statically bundled library? how did we before?
clear contents
stop / cancel?
load first section
load other sections
scroll to section
preview

Needs some discussion with iOS to understand how this will work with their file based approach in the near and long term.

This is really hazy because there's some general library and page state functionality here:
apps-android-wikipedia/www/tests/pingback.js - debug
apps-android-wikipedia/www/js/transformer.js - registration, decor -- this is less lib like and more framework like tho
apps-android-wikipedia/www/js/main.js
apps-android-wikipedia/www/js/sections.js
add faculty to report library version to native land
set library state (app locale, decor offset, ...)
set page state (rtl, margins, padding, page is protected)
get page state (get list of images? text selection, find in page (/home/stephen/dev/wmf/bk/apps-ios-wikipedia/www/js/findInPage.js /home/stephen/dev/wmf/bk/apps-ios-wikipedia/www/less/findInPage.less), do we want to provide unmarshalling? request current section used by toc)
apps-android-wikipedia/www/js/rtlsupport.js

iOS has replaced the transformer with called from native land: https://github.com/wikimedia/wikipedia-ios/pull/1390/files#diff-d5baead480087a43ea809e1654407a19

generic bridge callback registration

some really basic lifecycle events like dom loaded
apps-android-wikipedia/www/js/bridge.js

document.onclick

apps-android-wikipedia/www/js/action.js
wikipedia-ios/www/js/listeners.js

Event Timeline

Niedzielski renamed this task from Consolidate page loading to Consolidate page loading, library state.May 2 2017, 10:58 PM
Niedzielski updated the task description. (Show Details)
Mhurd subscribed.

Closing this given the upcoming switch to PCS is page based not section based, many of the files mentioned above will no longer exist after this transition.