Page MenuHomePhabricator

Arrow keys for rotating models interfere with navigation in gallery
Open, HighPublic

Description

Steps to reproduce:

  1. Go to https://en.wikipedia.beta.wmflabs.org/wiki/PreviewsWith3DImage/sandbox
  2. Click the first image.
  3. Press the left arrow key. -> The model rotates as expected.
  4. Press the right arrow key. -> You navigate to the next image instead of rotating back.

I don't know what's the best behavior here, it probably needs some explicit focus management to decide which element should respond to the arrow keys.

Event Timeline

@Nirzar out impression is that the arrow keys shouldn't interact with the 3D UI, as they're reserved for MediaViewer. However, what approach would you like to take? Add a D-pad to the UI, with potential key bindings (e.g., Vim)? Or do nothing?

It would seem in any case we probably need to remove the left arrow key binding in 3D.

...depending on approach we may be talking here about upstreaming some fixes or enhancements.

dr0ptp4kt renamed this task from Arrow keys for rotating models interfer with navigation in gallery to Arrow keys for rotating models interfere with navigation in gallery .Jun 12 2017, 10:25 PM
dr0ptp4kt moved this task from Untriaged to Next up on the Multimedia board.

Per discussion with @Nirzar key bindings for 3D should be disabled and the default key bindings for Media Viewer should be in force. A d-pad is in the works and the buttons on that will be operable with the keyboard.

Upon further discussion, @Nirzar to provide guidance on alternative key-mappings, probably using COMMAND/CTRL depending on platform.

Change 358979 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] Disable 3D rotation by keys

https://gerrit.wikimedia.org/r/358979

Change 358979 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Disable 3D rotation by keys

https://gerrit.wikimedia.org/r/358979

@Nirzar what a11y treatment do we want for this for users who do not work with mice for such interactions?

We need to add keyboard shortcuts for and zooming.

cmd + arrow keys for rotate. people without mice and trackpads should be able to interact with objects.

I did work on a treatment to display the shortcuts but I was trying to figure out the trigger to do so.

popover.png (1×2 px, 280 KB)

Thanks, @Nirzar. @MarkTraceur is this technically feasible on the critical mass of desktop UAs?

Should those labels fade out once a user started interacting with the object?

that was the idea.. sorry I'm not being super clear about design spec here because it was still WIP and we decided to keep this as a non-blocker but if people are interested in this I can fill in more details in the task description

@Nirzar if it isn't too much time to fill in the details, yes, that would be nice - thanks!

Removing @Nirzar as assignee, as that account has been disabled.