Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Compilations: close the loop. | apps/android/wikipedia | master | +572 -97 | |
WIP: Execute download of compilations. | apps/android/wikipedia | master | +177 -47 |
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 367894 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Initiate download of compilation via overflow menu.
Comment Actions
Change 367895 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] WIP: Execute download of compilations.
Comment Actions
Change 367894 merged by jenkins-bot:
[apps/android/wikipedia@master] Compilations: close the loop.
Comment Actions
Moving along as this ticket about the *action* of executing a download can be done. Will post UI-related feedback on T167523.
Tested on Nexus 5 (Android 6.0.1) on Wikipedia v2.6.200-alpha-2017-08-08
QA steps to test
- Tap on the overflow menu on the Explore feed and select to go to "Offline compilations"
- Tap from "Offline compilations" to "Add an offline compilation"
- Tap on an overflow menu for one of the compilations available, it is expected that there should be a menu option to download.
- Select the download from the overflow menu. It is expected that the download will be executed for that compilation.
- Now tap on another offline compilation to open its details screen, which should show more details about the compilation including an action to "DOWNLOAD" it
- It is expected that upon tapping the action will execute the download for that compilation.
Comment Actions
Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.201-alpha-2017-08-11
Looks good to me