Page MenuHomePhabricator
Create Task
Maniphest T165843

Remove jshint and jscs in favour of eslint (linting and code style) in Wikidata code
Closed, ResolvedPublic
Actions

Description

@Jdforrester-WMF is happy to write the patches, but there's the scope for minor disruption if there are a lot of local exceptions (e.g. lots of manual rebasing needed) and we don't want to break actual code writing workflows.

Wikibase libs:

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.May 20 2017, 9:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2017, 9:04 AM
WMDE-leszek subscribed.May 20 2017, 9:06 AM
gerritbot subscribed.May 20 2017, 10:14 AM

Change 350378 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] [WIP] Use eslint for linting JavaScript code

https://gerrit.wikimedia.org/r/350378

gerritbot added a project: Patch-For-Review.May 20 2017, 10:14 AM
WMDE-leszek updated the task description. (Show Details)May 20 2017, 10:15 AM
WMDE-leszek added a comment.May 20 2017, 10:17 AM

@Jdforrester-WMF I was also planning to spend some time on this, nice to see I might not be alone!
Regarding manual rebasing etc interruptions, I can take it on me.
I guess we might also want to switch libraries hosted on github (DataValues, DataModel js etc) at some point.

gerritbot added a comment.May 20 2017, 2:09 PM

Change 354696 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Lint JS with jslint instead of jscs and jshint

https://gerrit.wikimedia.org/r/354696

WMDE-leszek mentioned this in rEWLE4383bd1f7399: Lint JS with jslint instead of jscs and jshint.May 20 2017, 2:13 PM
WMDE-leszek mentioned this in rEWLE1096a610d1b0: Lint JS with jslint instead of jscs and jshint.May 20 2017, 2:32 PM
WMDE-leszek mentioned this in rEWLE09850213efbf: Lint JS with eslint instead of jscs and jshint.
WMDE-leszek mentioned this in rEWLEde94cf20928d: Lint JS with eslint instead of jscs and jshint.May 21 2017, 7:32 AM
WMDE-leszek mentioned this in rEWLE5c65bcb1d317: Lint JS with eslint instead of jscs and jshint.May 21 2017, 10:27 AM
gerritbot added a comment.May 21 2017, 11:43 AM

Change 354952 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseMediaInfo@master] Lint JavaScript with eslint instead of jscs and jshint

https://gerrit.wikimedia.org/r/354952

WMDE-leszek mentioned this in rEWBI6e732fac123e: Lint JavaScript with eslint instead of jscs and jshint.May 21 2017, 11:43 AM
WMDE-leszek mentioned this in rEWBI2248a070a1be: Lint JavaScript with eslint instead of jscs and jshint.May 21 2017, 12:14 PM
WMDE-leszek mentioned this in rEWBIb45e576b7989: Lint JavaScript with eslint instead of jscs and jshint.May 21 2017, 12:19 PM
gerritbot added a comment.May 21 2017, 12:59 PM

Change 354973 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354973

gerritbot added a comment.May 21 2017, 1:18 PM

Change 354979 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseQuality@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354979

gerritbot added a comment.May 21 2017, 1:27 PM

Change 354981 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354981

gerritbot added a comment.May 21 2017, 1:46 PM

Change 354986 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/ArticlePlaceholder@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354986

gerritbot added a comment.May 21 2017, 2:01 PM

Change 354989 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikidata.org@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354989

gerritbot added a comment.May 21 2017, 2:11 PM

Change 354991 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikimediaBadges@master] Use eslint to lint JavaScript instead of jshint

https://gerrit.wikimedia.org/r/354991

gerritbot added a comment.May 22 2017, 4:04 AM

Change 354986 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354986

gerritbot added a comment.May 22 2017, 1:16 PM

Change 354696 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Lint JS with eslint instead of jscs and jshint

https://gerrit.wikimedia.org/r/354696

WMDE-leszek updated the task description. (Show Details)May 23 2017, 11:25 AM
gerritbot added a comment.May 23 2017, 2:27 PM

Change 355224 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[data-values/value-view@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/355224

gerritbot added a comment.May 25 2017, 8:20 AM

Change 354973 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354973

gerritbot added a comment.May 25 2017, 2:03 PM

Change 354981 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354981

gerritbot added a comment.May 25 2017, 2:03 PM

Change 354979 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQuality@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354979

WMDE-leszek updated the task description. (Show Details)May 29 2017, 7:33 AM
gerritbot added a comment.May 30 2017, 7:58 PM

Change 355224 merged by jenkins-bot:
[data-values/value-view@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/355224

gerritbot added a comment.Jun 1 2017, 8:27 AM

Change 350378 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use eslint for linting JavaScript code

https://gerrit.wikimedia.org/r/350378

WMDE-leszek updated the task description. (Show Details)Jun 1 2017, 8:33 AM
Jdforrester-WMF updated the task description. (Show Details)Jun 1 2017, 3:07 PM
gerritbot added a comment.Jun 1 2017, 3:25 PM

Change 354952 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Lint JavaScript with eslint instead of jscs and jshint

https://gerrit.wikimedia.org/r/354952

gerritbot added a comment.Jun 1 2017, 3:25 PM

Change 354989 merged by jenkins-bot:
[mediawiki/extensions/Wikidata.org@master] Use eslint to lint JavaScript instead of jscs and jshint

https://gerrit.wikimedia.org/r/354989

gerritbot added a comment.Jun 1 2017, 3:29 PM

Change 354991 merged by jenkins-bot:
[mediawiki/extensions/WikimediaBadges@master] Use eslint to lint JavaScript instead of jshint

https://gerrit.wikimedia.org/r/354991

Jdforrester-WMF removed a project: Patch-For-Review.Jun 1 2017, 3:29 PM
Jdforrester-WMF updated the task description. (Show Details)
WMDE-leszek updated the task description. (Show Details)Jun 1 2017, 3:31 PM
WMDE-leszek updated the task description. (Show Details)Jun 1 2017, 4:00 PM
gerritbot added a comment.Jul 10 2017, 4:11 PM

Change 364235 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseJavaScriptApi@master] Lint JS with eslint

https://gerrit.wikimedia.org/r/364235

gerritbot added a project: Patch-For-Review.Jul 10 2017, 4:11 PM
gerritbot added a comment.Jul 12 2017, 1:48 PM

Change 364235 merged by jenkins-bot:
[mediawiki/extensions/WikibaseJavaScriptApi@master] Lint JS with eslint

https://gerrit.wikimedia.org/r/364235

Ladsgroup updated the task description. (Show Details)Jul 19 2017, 12:26 PM
Ladsgroup updated the task description. (Show Details)Jul 19 2017, 2:27 PM
Ladsgroup updated the task description. (Show Details)Jul 22 2017, 6:57 AM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 22 2017, 6:57 AM
Ladsgroup updated the task description. (Show Details)Jul 29 2017, 8:38 PM
Ladsgroup updated the task description. (Show Details)Jul 31 2017, 2:18 PM
Ladsgroup updated the task description. (Show Details)Jul 31 2017, 6:27 PM
Ladsgroup closed this task as Resolved.Aug 1 2017, 10:58 AM
Ladsgroup updated the task description. (Show Details)
Ladsgroup removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL