Page MenuHomePhabricator
Create Task
Maniphest T167478

SkinStyles registered via ResourceModuleSkinStyles do not work on classes other than ResourceLoaderFileModule
Closed, ResolvedPublic
Actions

Description

MFResourceLoaderParsedMessageModule extends ResourceLoaderFileModule

However, skinStyles registered via ResourceModuleSkinStyles are not registered for modules that specify the class MFResourceLoaderParsedMessageModule.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclassmediawiki/coremaster+8 -5
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jun 8 2017, 11:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 11:18 PM
Legoktm added subscribers: matmarex, Legoktm.Jun 9 2017, 4:30 AM

+cc @matmarex, see related https://gerrit.wikimedia.org/r/#/c/357327/ - we'll need to implement a general solution for this.

matmarex claimed this task.Jun 9 2017, 7:37 AM
Krinkle triaged this task as High priority.Jun 14 2017, 9:35 PM
Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.
Jdlrobson moved this task from Needs Prioritization to 2014-15 Q4 on the Web-Team-Backlog-Archived board.Jun 15 2017, 5:51 PM
gerritbot subscribed.Jun 16 2017, 7:18 PM

Change 357327 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclass

https://gerrit.wikimedia.org/r/357327

gerritbot added a project: Patch-For-Review.Jun 16 2017, 7:18 PM
gerritbot added a comment.Jun 21 2017, 7:53 PM

Change 357327 merged by jenkins-bot:
[mediawiki/core@master] Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclass

https://gerrit.wikimedia.org/r/357327

matmarex closed this task as Resolved.Jun 21 2017, 8:01 PM
matmarex removed a project: Patch-For-Review.
MBinder_WMF moved this task from 2014-15 Q4 to 2016-17 Q4 on the Web-Team-Backlog-Archived board.Mar 6 2018, 6:58 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptMar 6 2018, 6:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits