Page MenuHomePhabricator

Impossible to expand menu for adding student on course page
Closed, ResolvedPublic

Description

After clicking on [Expand] at the bottom of the page, no content is expanded. Might be related to recent changes in core (rMW2d95d36a8ed296813e686e9b756c2bb7c306950f, rMW15b88fc2807c21c4fbefbb75ba2433d3d150b34a, rMW91edf9c398af4b87993ae4513bd66138626aee28).

Details

Related Gerrit Patches:
mediawiki/extensions/EducationProgram : masterViewCourseAction: Fix "Add students" menu not being expandable

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2017, 10:23 AM
matej_suchanek renamed this task from Impossible to exapnd menu for adding student on course page to Impossible to expand menu for adding student on course page.Jun 12 2017, 10:23 AM

Anything printed in the web browser's error console when going to https://cs.wikipedia.org/wiki/Kurz:Workshopy/Wikiměsto_Litovel_()?debug=true ?

Apart from "Sbalit / Rozbalit" under "Shrnutí" (first table) I don't see any "expand" menu option (I guess I need special permissions).

Anything printed in the web browser's error console when going to https://cs.wikipedia.org/wiki/Kurz:Workshopy/Wikiměsto_Litovel_()?debug=true ?

Nothing. Niether safemode makes difference.

Apart from "Sbalit / Rozbalit" under "Shrnutí" (first table) I don't see any "expand" menu option (I guess I need special permissions).

Yeah, that's true.

matmarex claimed this task.Jun 12 2017, 8:38 PM

I've temporarily granted myself "course coordinator" rights ("koordinátor kurzu") on cs.wp to debug this: https://cs.wikipedia.org/wiki/Speciální:Protokolovací_záznamy/Bartosz_Dziewoński_(WMF)

For reference, here's how the page looks like for users who can add students to the course:

This is the same kind of issue as T166298, and rMW15b88fc2807c21c4fbefbb75ba2433d3d150b34a does not resolve this case. EducationProgram generates a custom toggle with an <a href="#"> tag, and jquery.makeCollapsible thinks this is a real link and ignores clicks on it.

The simplest fix is to just remove the href="#" attribute, it's not needed for anything – patch incoming. We could also consider undoing some more bits of rMW2d95d36a8ed296813e686e9b756c2bb7c306950f to make the toggle not be ignored again.

Change 358479 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/EducationProgram@master] ViewCourseAction: Fix "Add students" menu not being expandable

https://gerrit.wikimedia.org/r/358479

Change 358479 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@master] ViewCourseAction: Fix "Add students" menu not being expandable

https://gerrit.wikimedia.org/r/358479

Worth backporting? I'd like to tell fellows when this is actually fixed.

matmarex added a subscriber: ReleaseTaggerBot.

@ReleaseTaggerBot is wrong here and this change made it into 1.30.0-wmf.5 (just barely), as you can check on the Gerrit change. This means that it will be deployed to the wikis this week. It will make it to Czech Wikipedia on Thursday, 15 June, around 22:00 local time (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20170615T1900).

matmarex closed this task as Resolved.Jun 14 2017, 6:11 PM
matmarex removed a project: Patch-For-Review.

Thanks! I followed the release tag which was indeed wrong.