After clicking on [Expand] at the bottom of the page, no content is expanded. Might be related to recent changes in core (rMW2d95d36a8ed296813e686e9b756c2bb7c306950f, rMW15b88fc2807c21c4fbefbb75ba2433d3d150b34a, rMW91edf9c398af4b87993ae4513bd66138626aee28).
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned Here
- T166298: Dropdown options of Upload Wizard are broken (copy metadata, add location and more, non-own-work license options)
rMW2d95d36a8ed2: Allow more customization on the default toggle system
rMW15b88fc2807c: jquery.makeCollapsible: Restore considering empty <a> as part of toggle
rMW91edf9c398af: Making the default toggle look clickable again
Event Timeline
Comment Actions
Anything printed in the web browser's error console when going to https://cs.wikipedia.org/wiki/Kurz:Workshopy/Wikiměsto_Litovel_()?debug=true ?
Apart from "Sbalit / Rozbalit" under "Shrnutí" (first table) I don't see any "expand" menu option (I guess I need special permissions).
Comment Actions
Nothing. Niether safemode makes difference.
Apart from "Sbalit / Rozbalit" under "Shrnutí" (first table) I don't see any "expand" menu option (I guess I need special permissions).
Yeah, that's true.
Comment Actions
I've temporarily granted myself "course coordinator" rights ("koordinátor kurzu") on cs.wp to debug this: https://cs.wikipedia.org/wiki/Speciální:Protokolovací_záznamy/Bartosz_Dziewoński_(WMF)
Comment Actions
For reference, here's how the page looks like for users who can add students to the course:
Comment Actions
This is the same kind of issue as T166298, and rMW15b88fc2807c21c4fbefbb75ba2433d3d150b34a does not resolve this case. EducationProgram generates a custom toggle with an <a href="#"> tag, and jquery.makeCollapsible thinks this is a real link and ignores clicks on it.
The simplest fix is to just remove the href="#" attribute, it's not needed for anything – patch incoming. We could also consider undoing some more bits of rMW2d95d36a8ed296813e686e9b756c2bb7c306950f to make the toggle not be ignored again.
Comment Actions
Change 358479 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/EducationProgram@master] ViewCourseAction: Fix "Add students" menu not being expandable
Comment Actions
Change 358479 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@master] ViewCourseAction: Fix "Add students" menu not being expandable
Comment Actions
@ReleaseTaggerBot is wrong here and this change made it into 1.30.0-wmf.5 (just barely), as you can check on the Gerrit change. This means that it will be deployed to the wikis this week. It will make it to Czech Wikipedia on Thursday, 15 June, around 22:00 local time (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20170615T1900).