Dropdown options for copying fields to other images, and for further information including location do not work today. They worked yesterday.
Reported on Commons:
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | thcipriani | T163512 MW-1.30.0-wmf.2 deployment blockers | |||
| Resolved | matmarex | T166298 Dropdown options of Upload Wizard are broken (copy metadata, add location and more, non-own-work license options) |
Event Timeline
Comment Actions
I can reliably reproduce this. No obvious errors in console.
Wednesday => probably MediaWiki train. The only recent change in UW's code is 3740018, so cc @matthiasmullie.
Comment Actions
I believe the issue is not in UW (works on my local machine) but in core (stopped working on my machine when I updated that)
I'll keep looking into this.
Comment Actions
Change 355642 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/UploadWizard@master] Unbreak usages of $.fn.makeCollapsible with custom <a> toggle
Comment Actions
Thanks for the pointer Matthias, I remembered a change related to makeCollapsible() that was merged recently (2d95d36a8ed296813e686e9b756c2bb7c306950f) and I was able to easily confirm it was the problem. The workaround above fixes the problem for us.
Comment Actions
Change 355642 abandoned by Bartosz Dziewoński:
Unbreak usages of $.fn.makeCollapsible with custom <a> toggle
Reason:
Alternative patch: https://gerrit.wikimedia.org/r/355715
Comment Actions
Change 355715 had a related patch set uploaded (by Bartosz Dziewoński; owner: Krinkle):
[mediawiki/core@master] jquery.makeCollapsible: Restore considering empty <a> as part of toggle
Comment Actions
Change 355715 merged by jenkins-bot:
[mediawiki/core@master] jquery.makeCollapsible: Restore considering empty <a> as part of toggle
Comment Actions
Change 355721 had a related patch set uploaded (by Bartosz Dziewoński; owner: Krinkle):
[mediawiki/core@wmf/1.30.0-wmf.2] jquery.makeCollapsible: Restore considering empty <a> as part of toggle
Comment Actions
I scheduled the fix for a SWAT deployment later today (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20170525T2300).
Comment Actions
Change 355721 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.2] jquery.makeCollapsible: Restore considering empty <a> as part of toggle
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-05-25T23:44:46Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.2/resources/src/jquery/jquery.makeCollapsible.js: SWAT: [[gerrit:355721|jquery.makeCollapsible: Restore considering empty <a> as part of toggle]] T166298 (duration: 00m 42s)